Skip to content

ref(components): convert StackedAreaChart from class to function component #109601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaKGoldberg wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −9
Open

ref(components): convert StackedAreaChart from class to function component #109601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions static/app/components/charts/stackedAreaChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
import {Component} from 'react';

import type {AreaChartProps} from 'sentry/components/charts/areaChart';
import {AreaChart} from 'sentry/components/charts/areaChart';

class StackedAreaChart extends Component<AreaChartProps> {
render() {
return <AreaChart tooltip={{filter: val => val > 0}} {...this.props} stacked />;
}
function StackedAreaChart(props: AreaChartProps) {
return <AreaChart tooltip={{filter: val => val > 0}} {...props} stacked />;
}

export default StackedAreaChart;
4 changes: 1 addition & 3 deletions static/app/views/releases/detail/overview/releaseComparisonChart/releaseSessionsChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,7 @@ class ReleaseSessionsChart extends Component<Props> {
}
}

getChart():
| React.ComponentType<StackedAreaChart['props']>
| React.ComponentType<AreaChartProps> {
getChart(): React.ComponentType<AreaChartProps> {
Copy link
Member Author

@JoshuaKGoldberg JoshuaKGoldberg Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StackedAreaChart['props'] was AreaChartProps already! Duplicate type constituents. https://typescript-eslint.io/rules/no-duplicate-type-constituents/

const {chartType} = this.props;
switch (chartType) {
case ReleaseComparisonChartType.CRASH_FREE_SESSIONS:
Expand Down
Loading