Skip to content

fix(tests): deflake useReplaysFromIssue test#114629

Open
ryan953 wants to merge 1 commit intomasterfrom
fix/flaky-test-useReplaysFromIssue
Open

fix(tests): deflake useReplaysFromIssue test#114629
ryan953 wants to merge 1 commit intomasterfrom
fix/flaky-test-useReplaysFromIssue

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented May 1, 2026

Summary

  • Move shared mutable fixtures (location, organization, MOCK_GROUP) from describe scope into each individual test to prevent reference sharing across re-render cycles
  • Split waitFor assertions: first wait for isFetching to settle to false, then assert eventView and fetchError synchronously outside waitFor to avoid deep-equal failures on transient intermediate states
  • Remove it.isKnownFlake marker from the "should fetch a list of replay ids" test

Test plan

  • CI passes on the previously flaky test
  • All three tests in the suite continue to pass

Move shared mutable fixtures (location, organization) from describe
scope into each test to prevent reference sharing across re-renders.
Split waitFor assertions to first wait for isFetching to settle, then
check eventView and fetchError synchronously, avoiding deep-equal
failures on transient intermediate states.
@ryan953 ryan953 requested a review from a team as a code owner May 1, 2026 21:34
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 1, 2026
@ryan953 ryan953 added the Frontend: Rerun Flaky Tests Known flaky tests should be run many times, just to be safe. label May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend: Rerun Flaky Tests Known flaky tests should be run many times, just to be safe. Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant