fix(tests): deflake useReplaysFromIssue test#114629
Open
Conversation
Move shared mutable fixtures (location, organization) from describe scope into each test to prevent reference sharing across re-renders. Split waitFor assertions to first wait for isFetching to settle, then check eventView and fetchError synchronously, avoiding deep-equal failures on transient intermediate states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
location,organization,MOCK_GROUP) fromdescribescope into each individual test to prevent reference sharing across re-render cycleswaitForassertions: first wait forisFetchingto settle tofalse, then asserteventViewandfetchErrorsynchronously outsidewaitForto avoid deep-equal failures on transient intermediate statesit.isKnownFlakemarker from the "should fetch a list of replay ids" testTest plan