Skip to content

fix(tests): deflake useReplaysFromIssue test #114629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryan953 wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −31
Open

fix(tests): deflake useReplaysFromIssue test #114629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 29 additions & 31 deletions static/app/views/issueDetails/groupReplays/useReplaysFromIssue.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@ describe('useReplaysFromIssue', () => {
},
};

const location = LocationFixture();

const organization = OrganizationFixture({
features: ['session-replay'],
});

it.isKnownFlake('should fetch a list of replay ids', async () => {
it('should fetch a list of replay ids', async () => {
const location = LocationFixture();
const organization = OrganizationFixture({
features: ['session-replay'],
});
const MOCK_GROUP = GroupFixture();

MockApiClient.addMockResponse({
Expand All @@ -41,19 +39,21 @@ describe('useReplaysFromIssue', () => {
initialRouterConfig,
});

await waitFor(() =>
expect(result.current).toEqual({
eventView: expect.objectContaining({
query: 'id:[replay42,replay256]',
}),
fetchError: undefined,
isFetching: false,
pageLinks: null,
await waitFor(() => expect(result.current.isFetching).toBe(false));

expect(result.current.eventView).toEqual(
expect.objectContaining({
query: 'id:[replay42,replay256]',
})
);
expect(result.current.fetchError).toBeUndefined();
});

it('should fetch a list of replay ids for a performance issue', async () => {
const location = LocationFixture();
const organization = OrganizationFixture({
features: ['session-replay'],
});
const MOCK_GROUP = GroupFixture({issueCategory: IssueCategory.PERFORMANCE});

MockApiClient.addMockResponse({
Expand All @@ -73,19 +73,21 @@ describe('useReplaysFromIssue', () => {
initialRouterConfig,
});

await waitFor(() =>
expect(result.current).toEqual({
eventView: expect.objectContaining({
query: 'id:[replay42,replay256]',
}),
fetchError: undefined,
isFetching: false,
pageLinks: null,
await waitFor(() => expect(result.current.isFetching).toBe(false));

expect(result.current.eventView).toEqual(
expect.objectContaining({
query: 'id:[replay42,replay256]',
})
);
expect(result.current.fetchError).toBeUndefined();
});

it('should return an empty EventView when there are no replay_ids returned from the count endpoint', async () => {
const location = LocationFixture();
const organization = OrganizationFixture({
features: ['session-replay'],
});
const MOCK_GROUP = GroupFixture();

MockApiClient.addMockResponse({
Expand All @@ -103,13 +105,9 @@ describe('useReplaysFromIssue', () => {
initialRouterConfig,
});

await waitFor(() =>
expect(result.current).toEqual({
eventView: null,
fetchError: undefined,
isFetching: false,
pageLinks: null,
})
);
await waitFor(() => expect(result.current.isFetching).toBe(false));

expect(result.current.eventView).toBeNull();
expect(result.current.fetchError).toBeUndefined();
});
});
Loading