fix(tests): deflake discover resultsSearchQueryBuilder tests#114630
Open
fix(tests): deflake discover resultsSearchQueryBuilder tests#114630
Conversation
Pre-populate TagStore before render to eliminate the race condition between async API response (populating TagStore) and user interaction. The supportedTags prop was never read by the component — tags came from TagStore populated by the /organizations/org-slug/tags/ API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
TagStore only has a named export, not a default export.
ryan953
commented
May 3, 2026
ryan953
commented
May 3, 2026
Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
ryan953
added
the
Frontend: Rerun Flaky Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TagStorebefore render inresultsSearchQueryBuilder.spec.tsxto eliminate the race condition between async API response and user interactionisKnownFlakemarkers from both tests now that the root cause is fixedsupportedTagsprop was declared but never read by the component — tags came fromTagStorepopulated asynchronously via the/organizations/org-slug/tags/APITest plan