Skip to content

fix(tests): deflake discover resultsSearchQueryBuilder tests #114630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryan953 wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −0
Open

fix(tests): deflake discover resultsSearchQueryBuilder tests #114630

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41996dc
fix(tests): Deflake discover resultsSearchQueryBuilder tests
ryan953 May 1, 2026
200fddd
fix: use named import for TagStore in test file
ryan953 May 1, 2026
cde0ff3
Apply suggestions from code review
ryan953 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions static/app/views/discover/results/resultsSearchQueryBuilder.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
within,
} from 'sentry-test/reactTestingLibrary';

import {TagStore} from 'sentry/stores/tagStore';
import {SavedSearchType} from 'sentry/types/group';
import type {Organization} from 'sentry/types/organization';
import {FieldKind} from 'sentry/utils/fields';
Expand All @@ -31,9 +32,15 @@ describe('ResultsSearchQueryBuilder', () => {
url: '/organizations/org-slug/tags/',
body: [{key: 'transaction', name: 'transaction', kind: FieldKind.FIELD}],
});
// Pre-populate TagStore to eliminate race between async API response and user interaction
TagStore.loadTagsSuccess([
{key: 'transaction', name: 'transaction'},
{key: 'environment', name: 'environment'},
{key: 'user', name: 'user'},
]);
});

it.isKnownFlake('does not show function tags in has: dropdown', async () => {
it('does not show function tags in has: dropdown', async () => {
Comment thread
ryan953 marked this conversation as resolved.
Outdated
render(
<ResultsSearchQueryBuilder
query=""
Expand Down Expand Up @@ -70,7 +77,7 @@ describe('ResultsSearchQueryBuilder', () => {
});
});

it.isKnownFlake('shows normal tags, e.g. transaction, in the dropdown', async () => {
it('shows normal tags, e.g. transaction, in the dropdown', async () => {
Comment thread
ryan953 marked this conversation as resolved.
Outdated
render(
<ResultsSearchQueryBuilder
query=""
Expand Down
Loading