Skip to content

Conversation

benvinegar
Copy link
Contributor

Summary of changes:

  • use classnames instead of joinClasses
  • use ReactDOM.findDOMNode instead of React.findDOMNode
  • deprecate usage of getDOMNode for direct ref or ReactDOM.findDOMNode
  • point to react 0.14-compatible versions of react dependencies (e.g. react-router)
  • import PureRenderMixin from new react-addons-pure-render-mixin package
  • fix assorted warnings

See: React 0.14 upgrade guide

See also:

@benvinegar benvinegar force-pushed the react-0.14 branch 5 times, most recently from 45ac6ff to 883f97a Compare October 14, 2015 23:50
@benvinegar benvinegar changed the title Upgrade to react 0.14 [WIP] Upgrade to react 0.14 Oct 14, 2015
@benvinegar
Copy link
Contributor Author

Okay, this PR is good to go. There's one final deprecation warning being thrown by react-sticky, but it doesn't affect anything. There's already an open PR to fix the warning on that project.

benvinegar added a commit that referenced this pull request Oct 19, 2015
@benvinegar benvinegar merged commit 964d061 into master Oct 19, 2015
@dcramer dcramer deleted the react-0.14 branch November 20, 2015 21:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant