Improve barchart rendering perf by deferring tooltip title creation #2202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also improves performance of the org dashboard. |
benvinegar
force-pushed
the
fast-barchart
branch
from
4c0f7e1 to
86f8317
Compare
|
lgtm |
|
This is based off the react-0.14 branch, so I will merge once #2172 lands. |
benvinegar
force-pushed
the
react-0.14
branch
from
c45c365 to
f2a7131
Compare
benvinegar
force-pushed
the
fast-barchart
branch
from
86f8317 to
cb9e13b
Compare
|
Closing because wrong target; see #2208 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my anecdotal testing with React.perf, this shaves > 100ms off of rendering from the stream (about 50% faster) and makes the page noticeably less janky on first render.