chore(launchpad): Return artifact URL upon creation #97558
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97558 +/- ##
==========================================
+ Coverage 80.26% 80.64% +0.37%
==========================================
Files 8561 8562 +1
Lines 377137 377168 +31
Branches 24548 24548
==========================================
+ Hits 302698 304153 +1455
+ Misses 74069 72645 -1424
Partials 370 370 |
NicoHinderling
force-pushed
the
artifact-url
branch
from
b49268f to
1bd623d
Compare
NicoHinderling
force-pushed
the
artifact-url
branch
from
683a008 to
09e6e83
Compare
| """ | ||
| organization: Organization = Organization.objects.get_from_cache(id=organization_id) | ||
|
|
||
| path = f"/organizations/{organization.slug}/preprod/internal/{artifact_id}" |
There was a problem hiding this comment.
Bug: Cross-Silo Query Violation in URL Construction
The get_preprod_artifact_url function queries the Organization model (Organization.objects.get_from_cache) from a region-silo endpoint to build a URL (using organization.slug and absolute_url). As Organization is a control-silo model, this violates silo boundaries, risking cross-silo database access errors (e.g., SiloLimitError) in multi-silo deployments. The URL should instead be constructed using data already available (e.g., project.organization) or a silo-safe service/mapping (e.g., OrganizationMapping or an organization_service) to avoid querying the control database from the region.
Instead of just returning the artifact id, lets return the full URL
Instead of just returning the artifact id, lets return the full URL