feat(build): replace assembly with action-build-push-images #1805
Conversation
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
| image_name: 'symbolicator' | ||
| platforms: linux/amd64,linux/arm64 | ||
| build_context: '/tmp/docker-ctx' | ||
| publish_on_pr: true # TEMPORARY FOR TESTING |
There was a problem hiding this comment.
self reminder to remove this before merging
| path: /tmp/symbolicator-${{ matrix.arch }}.tar | ||
|
|
||
| assemble-ghcr: | ||
| assemble: |
There was a problem hiding this comment.
I wonder if there's an argument towards keeping ghcr publishing and gar publishing separate jobs given a scenario where ghcr goes down, the job fails entirely and deploys are blocked. I like the idea of combining all this into one workflow though. WDYT @Dav1dde?
There was a problem hiding this comment.
I think it was just easier to deal with conditionals (publish to this or that) and docker credentials in separate jobs. Good idea to consolidate these.
|
this is ready for review at this point. multiarch was published to GAR here (will revert publish on prs before merging this PR):
i've pulled all 4 images and they work! |
| - name: Prepare Docker Context | ||
| run: | | ||
| mkdir docker-ctx | ||
| mkdir -p docker-ctx/binaries/linux/${{ matrix.arch }} | ||
| cp Dockerfile docker-ctx/ | ||
| mv symbolicator docker-ctx/ | ||
| mv symbolicator docker-ctx/binaries/linux/${{ matrix.arch }} |
There was a problem hiding this comment.
Why is this still happening if you upload the binary?
| path: /tmp/symbolicator-${{ matrix.arch }}.tar | ||
|
|
||
| assemble-ghcr: | ||
| assemble: |
There was a problem hiding this comment.
I think it was just easier to deal with conditionals (publish to this or that) and docker credentials in separate jobs. Good idea to consolidate these.
| # sanity check | ||
| RUN ["/bin/symbolicator", "help"] |
There was a problem hiding this comment.
Should definitely not merge this.
3 participants
redo of #1802; we need to preserve the docker tar building step for the self-hosted e2e tests
discussion here: https://github.com/getsentry/symbolicator/pull/1802/files#r2428050962
tl;dr it would be best to have the option to pass a docker tar so we don't have to rebuild with action-build-push-images, but we're lucky here that the build is so lightweight that this is acceptable in my mind for now. Tracked here: https://linear.app/getsentry/issue/DI-1382/action-build-and-push-images-should-have-the-option-to-take-a-docker