feat(build): replace assembly with action-build-push-images #1805
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,7 @@ jobs: | |
| }')[matrix.arch] }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
|
|
@@ -77,7 +77,7 @@ jobs: | |
| - name: Install sentry-cli | ||
| run: curl -sL https://sentry.io/get-cli/ | bash | ||
|
|
||
| - uses: swatinem/rust-cache@7939da402645ba29a2df566723491a2c856e8f8a # v2 | ||
| if: ${{ !startsWith(github.ref_name, 'release/') }} | ||
| with: | ||
| key: ${{ github.job }} | ||
|
|
@@ -88,6 +88,12 @@ jobs: | |
| cargo build --release --locked --target="${RUST_TARGET}" --features="${FEATURES}" | ||
| mv "target/${RUST_TARGET}/release/symbolicator" ./symbolicator | ||
|
|
||
| - name: Upload Binary | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 | ||
| with: | ||
| name: symbolicator-binary-${{ matrix.arch }} | ||
| path: ./symbolicator | ||
|
|
||
| - name: Split debug info | ||
| run: | | ||
| mkdir -p "/tmp/debug-info/" | ||
|
|
@@ -102,123 +108,88 @@ jobs: | |
| mv "${SOURCE_BUNDLE}" /tmp/debug-info/symbolicator-${{ matrix.arch }}.src.zip | ||
|
|
||
| - name: Upload Debug Info | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 | ||
| with: | ||
| name: symbolicator-debug@${{ matrix.arch }} | ||
| path: /tmp/debug-info/* | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435 # v3 | ||
|
|
||
| - name: Prepare Docker Context | ||
| run: | | ||
| mkdir -p docker-ctx/binaries/linux/${{ matrix.arch }} | ||
| cp Dockerfile docker-ctx/ | ||
| mv symbolicator docker-ctx/binaries/linux/${{ matrix.arch }} | ||
|
|
||
| - name: Build Image | ||
joshuarli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| uses: getsentry/action-build-and-push-images@b172ab61a5f7eabd58bd42ce231b517e79947c01 | ||
| with: | ||
| image_name: 'symbolicator' | ||
| tags: 'symbolicator-self-hosted' | ||
| platforms: linux/${{ matrix.arch }} | ||
| build_context: 'docker-ctx' | ||
| ghcr: false | ||
| google_ar: false | ||
| outputs: type=docker,dest=/tmp/symbolicator-${{ matrix.arch }}.tar | ||
|
|
||
| - name: Upload Image | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 | ||
| with: | ||
| name: symbolicator-image@${{ matrix.arch }} | ||
| path: /tmp/symbolicator-${{ matrix.arch }}.tar | ||
|
|
||
| assemble: | ||
|
There was a problem hiding this comment. I wonder if there's an argument towards keeping ghcr publishing and gar publishing separate jobs given a scenario where ghcr goes down, the job fails entirely and deploys are blocked. I like the idea of combining all this into one workflow though. WDYT @Dav1dde? There was a problem hiding this comment. I think it was just easier to deal with conditionals (publish to this or that) and docker credentials in separate jobs. Good idea to consolidate these. |
||
| needs: [build-setup, build-image] | ||
| if: "needs.build-setup.outputs.full_ci == 'true'" | ||
|
|
||
| name: Assemble | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: | ||
| packages: write # required for GHCR | ||
| contents: read | ||
| id-token: write # required for GAR | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 | ||
|
|
||
| - name: Download Binaries | ||
| uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5 | ||
| with: | ||
| pattern: symbolicator-binary-* | ||
| path: /tmp/docker-ctx | ||
|
|
||
| - name: Prepare Docker Context | ||
| run: | | ||
| cp Dockerfile /tmp/docker-ctx | ||
joshuarli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| mkdir -p /tmp/docker-ctx/binaries/linux/amd64 /tmp/docker-ctx/binaries/linux/arm64 | ||
| mv /tmp/docker-ctx/symbolicator-binary-amd64/symbolicator /tmp/docker-ctx/binaries/linux/amd64 | ||
| mv /tmp/docker-ctx/symbolicator-binary-arm64/symbolicator /tmp/docker-ctx/binaries/linux/arm64 | ||
|
|
||
| # If action-build-and-push-images supports passing in a docker tar, | ||
| # then we can reuse the image artifact rather than this workaround | ||
| # (thankfully the build amounts to just a cp, wouldn't be doing this | ||
| # if the build was more complicated as we're building twice) | ||
| - name: Build and push images | ||
| if: "needs.build-setup.outputs.full_ci == 'true'" | ||
| uses: getsentry/action-build-and-push-images@b172ab61a5f7eabd58bd42ce231b517e79947c01 | ||
| with: | ||
| image_name: 'symbolicator' | ||
joshuarli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # Please note that multiplatform builds like this are only feasible in this case | ||
| # because the docker build essentially amounts to copying files, not compiling. | ||
| platforms: linux/amd64,linux/arm64 | ||
| build_context: '/tmp/docker-ctx' | ||
| publish_on_pr: true # TEMPORARY FOR TESTING | ||
|
There was a problem hiding this comment. self reminder to remove this before merging |
||
| ghcr: true | ||
| google_ar: true | ||
| # note: nightly will only be tagged if on default branch | ||
| tag_nightly: true | ||
| # on GAR we expect latest tags, nightly is canonically only a GHCR thing for us | ||
| tag_latest: true | ||
| google_ar_image_name: us-central1-docker.pkg.dev/sentryio/symbolicator/image | ||
| google_workload_identity_provider: projects/868781662168/locations/global/workloadIdentityPools/prod-github/providers/github-oidc-pool | ||
| google_service_account: [email protected] | ||
|
|
||
| gocd-artifacts: | ||
| needs: [build-setup, build-image] | ||
|
|
@@ -234,17 +205,17 @@ jobs: | |
| steps: | ||
| - name: Google Auth | ||
| id: auth | ||
| uses: google-github-actions/auth@7c6bc770dae815cd3e89ee6cdf493a5fab2cc093 # v3 | ||
| with: | ||
| workload_identity_provider: projects/868781662168/locations/global/workloadIdentityPools/prod-github/providers/github-oidc-pool | ||
| service_account: [email protected] | ||
|
|
||
| - name: Set up Cloud SDK | ||
| uses: google-github-actions/setup-gcloud@aa5489c8933f4cc7a4f7d45035b3b1440c9c10db # v3 | ||
| with: | ||
| version: ">= 390.0.0" | ||
|
|
||
| - uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5 | ||
| with: | ||
| pattern: "symbolicator-debug@*" | ||
| path: /tmp/debug-info/ | ||
|
|
@@ -261,17 +232,19 @@ jobs: | |
|
|
||
| steps: | ||
| - name: Download Docker Image | ||
| uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5 | ||
| with: | ||
| pattern: symbolicator-image@amd64 | ||
| path: /tmp | ||
|
|
||
| - name: Load Docker Image | ||
| run: | | ||
| docker load --input /tmp/symbolicator-amd64.tar | ||
| docker image ls | ||
|
|
||
| - name: Run Sentry self-hosted e2e CI | ||
| uses: getsentry/self-hosted@6ae40d837a78c2968a28acf952b1beb9911237f8 # master | ||
| with: | ||
| project_name: symbolicator | ||
| image_url: symbolicator-self-hosted | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this still happening if you upload the binary?