Skip to content

Conversation

@bmckerry
Copy link
Member

@bmckerry bmckerry commented Oct 30, 2025

The filestore.profile-options storage location defaults to /tmp/sentry-profiles. This changes the volume mount source to be the same as the option default.

@bmckerry bmckerry marked this pull request as ready for review October 30, 2025 20:18
@bmckerry bmckerry requested a review from a team as a code owner October 30, 2025 20:18
SENTRY_SNUBA_HOST: http://127.0.0.1:1218
volumes:
- sentry-vroom:/var/lib/sentry-profiles
- /tmp/sentry-profiles:/var/lib/sentry-profiles
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Docker bind mount to /tmp/sentry-profiles fails because the host directory is not created, preventing vroom service startup.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The configuration in devservices/config.yml changes the vroom service to use a host path bind mount to /tmp/sentry-profiles instead of a Docker named volume. When a developer attempts to run the vroom service via devservices, Docker will fail to start the container because the host directory /tmp/sentry-profiles does not exist. There is no logic in the Dockerfile, vroom code, or setup scripts to create this directory, nor is there documentation requiring developers to pre-create it.

💡 Suggested Fix

Ensure the /tmp/sentry-profiles host directory is created before the Docker container attempts to bind mount it. This can be achieved by adding a mkdir command to a setup script or the Dockerfile, or by reverting to a Docker named volume.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: devservices/config.yml#L26

Potential issue: The configuration in `devservices/config.yml` changes the vroom service
to use a host path bind mount to `/tmp/sentry-profiles` instead of a Docker named
volume. When a developer attempts to run the vroom service via devservices, Docker will
fail to start the container because the host directory `/tmp/sentry-profiles` does not
exist. There is no logic in the Dockerfile, vroom code, or setup scripts to create this
directory, nor is there documentation requiring developers to pre-create it.

Did we get this right? 👍 / 👎 to inform future reviews.

@bmckerry bmckerry enabled auto-merge October 30, 2025 20:23
@bmckerry bmckerry merged commit ea894b6 into main Oct 30, 2025
17 checks passed
@bmckerry bmckerry deleted the ben/fix-env-var branch October 30, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants