Skip to content

fix: mount vroom volume to the storage option default #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmckerry merged 3 commits into from
Oct 30, 2025
Merged

fix: mount vroom volume to the storage option default #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3215a8
fix: env var
bmckerry Oct 30, 2025
bd9f105
remove volume
bmckerry Oct 30, 2025
538d7a6
update changelog
bmckerry Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@
- Reduce read jobs buffer to reduce memory usage. ([#584](https://github.com/getsentry/vroom/pull/584))
- Update GoCD scripts to use console script entry points. ([#608](https://github.com/getsentry/vroom/pull/608))
- Fix Craft's changelog bump entry. ([#640](https://github.com/getsentry/vroom/pull/640))
- Change devservices source volume mount location ([#653](https://github.com/getsentry/vroom/pull/653))

## 23.12.0

Expand Down
5 changes: 1 addition & 4 deletions devservices/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ services:
SENTRY_BUCKET_PROFILES: file://localhost//var/lib/sentry-profiles
SENTRY_SNUBA_HOST: http://127.0.0.1:1218
volumes:
- sentry-vroom:/var/lib/sentry-profiles
- /tmp/sentry-profiles:/var/lib/sentry-profiles
Copy link

@sentry sentry bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Docker bind mount to /tmp/sentry-profiles fails because the host directory is not created, preventing vroom service startup.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The configuration in devservices/config.yml changes the vroom service to use a host path bind mount to /tmp/sentry-profiles instead of a Docker named volume. When a developer attempts to run the vroom service via devservices, Docker will fail to start the container because the host directory /tmp/sentry-profiles does not exist. There is no logic in the Dockerfile, vroom code, or setup scripts to create this directory, nor is there documentation requiring developers to pre-create it.

💡 Suggested Fix

Ensure the /tmp/sentry-profiles host directory is created before the Docker container attempts to bind mount it. This can be achieved by adding a mkdir command to a setup script or the Dockerfile, or by reverting to a Docker named volume.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: devservices/config.yml#L26

Potential issue: The configuration in `devservices/config.yml` changes the vroom service
to use a host path bind mount to `/tmp/sentry-profiles` instead of a Docker named
volume. When a developer attempts to run the vroom service via devservices, Docker will
fail to start the container because the host directory `/tmp/sentry-profiles` does not
exist. There is no logic in the Dockerfile, vroom code, or setup scripts to create this
directory, nor is there documentation requiring developers to pre-create it.

Did we get this right? 👍 / 👎 to inform future reviews.

networks:
- devservices
extra_hosts:
Expand All @@ -32,9 +32,6 @@ services:
- orchestrator=devservices
restart: unless-stopped

volumes:
sentry-vroom:

networks:
devservices:
name: devservices
Expand Down
Loading