Skip to content

Conversation

@ryanseq-gyg
Copy link
Contributor

@ryanseq-gyg ryanseq-gyg commented Nov 14, 2025

Description

  • Refactored all the unit tests and consolidated them under parameterised unit tests
  • Standardise the format of the tests. This should make it easier to write new tests
  • Changed the publish github workflow to trigger manually

Checklist

  • Tests have been added in the prescribed format
  • Commit messages follow Conventional Commits format
  • Pre-commit hooks pass locally

@ryanseq-gyg ryanseq-gyg marked this pull request as ready for review November 18, 2025 19:18
@ryanseq-gyg ryanseq-gyg requested a review from a team as a code owner November 18, 2025 19:18
@ryanseq-gyg ryanseq-gyg requested a review from Copilot November 18, 2025 19:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates test files for aggregation "any value" expectations by removing individual test files and reorganizing the test structure. The changes update the test directory path in the sanity checks script, modify the stub file generation, and adjust CI workflow configurations.

Reviewed Changes

Copilot reviewed 45 out of 80 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/expectations_implemented/aggregation_expectations/any_value_expectations/*.py Removed individual test files for unique_rows, min_rows, max_rows, max_null_percentage, max_null_count, and distinct column value expectations
tests/expectations/column/string_expectations/*.py Added new test files for string expectations including starts_with, not_contains, length_less_than, length_greater_than, length_equals, and length_between
scripts/sanity_checks.py Updated tests directory path from tests/expectations_implemented to tests/expectations
dataframe_expectations/suite.pyi Updated stub file with new class definitions and method signatures
.github/workflows/publish.yaml Changed from tag-based to manual workflow dispatch
.github/workflows/main.yaml Removed pull_request trigger from CI workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryanseq-gyg ryanseq-gyg merged commit 509dcc3 into main Nov 18, 2025
8 checks passed
@ryanseq-gyg ryanseq-gyg deleted the cleanup-unit-tests branch November 18, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants