Skip to content

[deno] Fix some problems in the handling of device limits #8085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

andyleiserson
Copy link
Contributor

@andyleiserson andyleiserson commented Aug 11, 2025

Fix two problems with the handling of device limits:

  • Deno was raising a TypeError when a value was over the limit, but it should be an OperationError.
  • Requesting a limit value below WebGPU's default should ignore the requested value and substitute the default value of such limits.

Testing
Enables some CTS tests.

Squash or Rebase? Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@andyleiserson andyleiserson force-pushed the limits-operation-error branch from 9d2cb8d to b500ca9 Compare August 18, 2025 00:30
@andyleiserson andyleiserson changed the title [deno] Correct error type when a requested limit is too high [deno] Fix some problems in the handling of device limits Aug 18, 2025
@andyleiserson andyleiserson force-pushed the limits-operation-error branch from b36e128 to 03bca7d Compare August 18, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants