Removed const references for simple types and structures less 16 bytes #11294
      
        
          +4
        
        
          −4
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
As a minor improvement,
std::stringis made as param by constant reference, andprobs_iterator tmphas become constant iterator.In general, passing simple types and objects less than 16 bytes by reference makes optimization worse by modern compiler because it strictly follows rules programmer. I don't know if this will affect -O2 and even more so -O3.
Reference: https://stackoverflow.com/a/3314034