Skip to content

Removed const references for simple types and structures less 16 bytes #11294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed const references for simple types and structures less 16 bytes #11294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/arg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ static std::vector<ggml_backend_dev_t> parse_device_list(const std::string & val
return devices;
}

static void add_rpc_devices(std::string servers) {
static void add_rpc_devices(const std::string & servers) {
auto rpc_servers = string_split<std::string>(servers, ',');
if (rpc_servers.empty()) {
throw std::invalid_argument("no RPC servers specified");
Expand Down
6 changes: 3 additions & 3 deletions ggml/src/gguf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,7 @@ struct gguf_writer {
buf.insert(buf.end(), val.begin(), val.end());
}

void write(const bool & val) const {
void write(const bool val) const {
const int8_t val8 = val ? 1 : 0;
write(val8);
}
Expand All @@ -1172,11 +1172,11 @@ struct gguf_writer {
write(std::string(val));
}

void write(const enum ggml_type & val) const {
void write(const enum ggml_type val) const {
write(int32_t(val));
}

void write(const enum gguf_type & val) const {
void write(const enum gguf_type val) const {
write(int32_t(val));
}

Expand Down
Loading