server : (webui) allow typing and submitting during llm response #11626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
approved these changes
Feb 3, 2025
ngxson
reviewed
Feb 3, 2025
| if (this.isGenerating) { | ||
| this.stopGeneration(); | ||
| while (this.isGenerating) { | ||
| await new Promise((resolve) => setTimeout(resolve, 10)); |
Collaborator
There was a problem hiding this comment.
Hmm on second thought, this is a bad user experience. User have no visibility that the next message has already been queued and will be send as long as the generation is complete.
I will have to revert this.
Contributor
Author
There was a problem hiding this comment.
Right, I failed to consider queued completions. It would be nice, maybe in a future PR to still handle the stop+send when enter is pressed, which would be equivalent to clicking the Stop button and then clicking the Send button.
ngxson
added a commit
that referenced
this pull request
Feb 3, 2025
ngxson
added a commit
that referenced
this pull request
Feb 3, 2025
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the disabled attribute on the textarea used for submitting responses and lets the user submit when they press enter, which stops a current llm response from continuing and inserts the user response after.
The Promise is just to wait for
generateMessageto finish and add its message withStorageUtils.appendMsg.This will close #11565