Skip to content

server : (webui) allow typing and submitting during llm response #11626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

server : (webui) allow typing and submitting during llm response #11626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified examples/server/public/index.html.gz
View file
Open in desktop
Binary file not shown.
1 change: 0 additions & 1 deletion examples/server/webui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ <h2 class="font-bold ml-4">Conversations</h2>
placeholder="Type a message (Shift+Enter to add a new line)"
v-model="inputMsg"
@keydown.enter.exact.prevent="sendMessage"
:disabled="isGenerating"
id="msg-input"
dir="auto"
></textarea>
Expand Down
8 changes: 8 additions & 0 deletions examples/server/webui/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,14 @@ const mainApp = createApp({
},
async sendMessage() {
if (!this.inputMsg) return;

if (this.isGenerating) {
this.stopGeneration();
while (this.isGenerating) {
await new Promise((resolve) => setTimeout(resolve, 10));
Copy link
Collaborator

@ngxson ngxson Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm on second thought, this is a bad user experience. User have no visibility that the next message has already been queued and will be send as long as the generation is complete.

I will have to revert this.

Copy link
Contributor Author

@woof-dog woof-dog Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I failed to consider queued completions. It would be nice, maybe in a future PR to still handle the stop+send when enter is pressed, which would be equivalent to clicking the Stop button and then clicking the Send button.

}
}

const currConvId = this.viewingConvId;

StorageUtils.appendMsg(currConvId, {
Expand Down