Skip to content

feat(CMakeLists): Add MSVC-specific compiler warning flags in CMake configuration #12206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat(CMakeLists): Add MSVC-specific compiler warning flags in CMake configuration #12206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2c859d
feat(CMakeLists): Add MSVC warning flags for ggml modules
scc-tw Mar 5, 2025
24bb918
chore: remove trailing whitespace
scc-tw Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ggml/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,19 @@ if (GGML_ALL_WARNINGS)

add_compile_options("$<$<COMPILE_LANGUAGE:C>:${C_FLAGS};${GF_C_FLAGS}>"
"$<$<COMPILE_LANGUAGE:CXX>:${CXX_FLAGS};${GF_CXX_FLAGS}>")
elseif(MSVC)
# MSVC
list(APPEND MSVC_WARNING_FLAGS
/W4 # Comprehensive warnings (similar to -Wall and some of -Wextra)
/we4456 # declaration hides previous local declaration
/we4457 # declaration hides function parameter
/we4458 # declaration hides class member
/wd4100 # unreferenced formal parameter (too noisy)
/wd4324 # structure was padded due to alignment specifier
)

add_compile_options(${MSVC_WARNING_FLAGS})
else()
# todo : msvc
set(C_FLAGS "")
set(CXX_FLAGS "")
endif()
Expand Down
Loading