tests : improve UGM tokenizer test coverage #13773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
May 25, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
We should avoid adding more vocab files because they increase the size of the repository significantly. Ideally, the tests should download these files from HF and we can avoid source-controlling them here.
We can merge this one for now.
Collaborator
Author
|
In that case it would make sense to have a vocab repo in ggml-org on HF? |
Member
|
Yes. If you (or anyone else) is interested in implementing this, I will invite you to the HF org so you can set the repo. LMK |
Collaborator
Author
|
Sure, I can do that, I sent a request. |
Collaborator
Author
|
@ngxson I need the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds nomic-bert-moe vocab for improved test coverage of UGM tokenizer.