eval-callback : stop on first NaN #15320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbolznv
reviewed
Aug 14, 2025
| } | ||
|
|
||
| if (std::isnan(sum)) { | ||
| exit(0); |
Collaborator
There was a problem hiding this comment.
A log message before exiting would be nice.
jeffbolznv
approved these changes
Aug 14, 2025
ggerganov
commented
Aug 14, 2025
| // TODO: make this abort configurable/optional? | ||
| if (std::isnan(sum)) { | ||
| LOG_ERR("encountered NaN - aborting\n"); | ||
| exit(0); |
Member
Author
There was a problem hiding this comment.
I think this should have been exit(1) ..
@copilot Can you fix this for me in a new PR?
Collaborator
There was a problem hiding this comment.
Unfortunately only works in PRs where Copilot is involved. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
llama-eval-callbackto stop on first tensor with a NaN. I think this is always useful when debugging - don't see a reason not to stop.