Skip to content

eval-callback : stop on first NaN #15320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

eval-callback : stop on first NaN #15320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2710edb
eval-callback : stop on first NaN
ggerganov Aug 14, 2025
eafa623
cont : log error
ggerganov Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions examples/eval-callback/eval-callback.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <cstdio>
#include <string>
#include <vector>
#include <numeric>

/**
* This the arbitrary data which will be passed to each callback.
Expand Down Expand Up @@ -77,6 +78,12 @@ static void ggml_print_tensor(uint8_t * data, ggml_type type, const int64_t * ne
LOG(" ]\n");
LOG(" sum = %f\n", sum);
}

// TODO: make this abort configurable/optional?
if (std::isnan(sum)) {
LOG_ERR("encountered NaN - aborting\n");
exit(0);
Copy link
Collaborator

@jeffbolznv jeffbolznv Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A log message before exiting would be nice.

Copy link
Member Author

@ggerganov ggerganov Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should have been exit(1) ..

@copilot Can you fix this for me in a new PR?

Copy link
Collaborator

@CISC CISC Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately only works in PRs where Copilot is involved. :)

}
}

/**
Expand Down
Loading