metal: add support for LOG op (f32, f16) #16530
Open
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
Summary
Adds support for the
LOG
operation to the Metal backend for bothf32
andf16
tensor types.Implementation details
ggml-metal.metal
:kernel_log_f32
kernel_log_f32_4
kernel_log_f16
kernel_log_f16_4
ggml-metal-device.m
to allow F16 for theLOG
op.LOG
into the unified unary op path (same asSIN
andCOS
).Validation
Tested on Apple M1 (MTLGPUFamilyApple7)