Skip to content

metal: add support for LOG op (f32, f16) #16530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −1
Open

metal: add support for LOG op (f32, f16) #16530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ggml/src/ggml-metal/ggml-metal-device.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ bool ggml_metal_device_supports_op(ggml_metal_device_t dev, const struct ggml_te
case GGML_OP_SIN:
case GGML_OP_COS:
case GGML_OP_LOG:
return ggml_is_contiguous(op->src[0]) && op->src[0]->type == GGML_TYPE_F32;
return ggml_is_contiguous(op->src[0]) && (op->src[0]->type == GGML_TYPE_F16 || op->src[0]->type == GGML_TYPE_F32);
case GGML_OP_SUM_ROWS:
case GGML_OP_MEAN:
case GGML_OP_SOFT_MAX:
Expand Down
17 changes: 17 additions & 0 deletions ggml/src/ggml-metal/ggml-metal.metal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,6 +1487,23 @@ kernel void kernel_log_f32_4(
dst[tpig] = log(src0[tpig]);
}

kernel void kernel_log_f16(
device const half * src0,
device half * dst,
uint tpig [[thread_position_in_grid]]) {
const float x = (float)src0[tpig];
dst[tpig] = (half)log(x);
}

kernel void kernel_log_f16_4(
device const half4 * src0,
device half4 * dst,
uint tpig [[thread_position_in_grid]]) {
const half4 xh = src0[tpig];
float4 xf = float4(xh);
dst[tpig] = half4(log(xf));
}

kernel void kernel_neg_f32(
device const float * src0,
device float * dst,
Expand Down