Skip to content

[branch-forward] Fix verify does not consider initial commit #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VikramGoyal23 merged 3 commits into from
Jan 7, 2026
Merged

[branch-forward] Fix verify does not consider initial commit #218

VikramGoyal23 merged 3 commits into from
Jan 7, 2026
+2 −0

Conversation

@jovnc
Copy link
Collaborator

@jovnc jovnc commented Jan 5, 2026

Exercise Review

Exercise Discussion

Fix #217

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested your changes using the instructions posted?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@jovnc jovnc requested a review from VikramGoyal23 January 5, 2026 15:09
@jovnc jovnc added priority.High bug Something isn't working labels Jan 5, 2026
VikramGoyal23
VikramGoyal23 requested changes Jan 6, 2026
View reviewed changes
Copy link
Collaborator

@VikramGoyal23 VikramGoyal23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works, thanks for the fix! Just one minor nit on the download.py file.

@jovnc jovnc requested a review from VikramGoyal23 January 6, 2026 15:25
@jovnc
Copy link
Collaborator Author

jovnc commented Jan 6, 2026

@VikramGoyal23 I've resolved the comments

VikramGoyal23
VikramGoyal23 approved these changes Jan 7, 2026
View reviewed changes
Copy link
Collaborator

@VikramGoyal23 VikramGoyal23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VikramGoyal23 VikramGoyal23 merged commit 80e19b1 into git-mastery:main Jan 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VikramGoyal23 VikramGoyal23 VikramGoyal23 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working priority.High

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[branch-forward] Verify does not consider initial commit

2 participants

@jovnc @VikramGoyal23