Skip to content

[branch-forward] Fix verify does not consider initial commit #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VikramGoyal23 merged 3 commits into from
Jan 7, 2026
+2 −0
Merged

[branch-forward] Fix verify does not consider initial commit #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f21a88
[branch-forward] Add checkout main in download.py
jovnc Jan 5, 2026
3d6e576
[branch-forward] Add initial state in verification logic
jovnc Jan 5, 2026
aedf94d
[branch-forward] Remove checkout main in download.py
jovnc Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions branch_forward/test_verify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
@contextmanager
def base_setup() -> Iterator[Tuple[GitAutograderTest, RepoSmith]]:
with loader.start() as (test, rs):
rs.git.commit(message="Set initial state", allow_empty=True)
rs.git.commit(message="Introduce Harry", allow_empty=True)
rs.git.commit(message="Add about family", allow_empty=True)

Expand Down
1 change: 1 addition & 0 deletions branch_forward/verify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
ONLY_WITH_SALLY_MERGED = "Only one of the two starting branches can be fast-forward merged into 'main'. Do not create new branches."

EXPECTED_MAIN_COMMIT_MESSAGES = {
"Set initial state",
"Introduce Harry",
"Add about family",
"Add cast.txt",
Expand Down