Merged
Conversation
small rename for an extra level of clarity
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames SuccessfulRebase::to_editor to SuccessfulRebase::into_editor to follow Rust naming conventions, since the method consumes self (takes ownership). The to_ prefix in Rust conventionally implies borrowing, while into_ implies ownership transfer.
Changes:
- Renamed
SuccessfulRebase::to_editor(self)tointo_editor(self)in its definition and single call site.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/but-rebase/src/graph_rebase/creation.rs |
Renames the method definition from to_editor to into_editor |
crates/but-workspace/src/commit/move_changes.rs |
Updates the sole call site to use the new name into_editor |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small rename for an extra level of clarity