Skip to content

to_editor -> into_editor #12798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estib-vega merged 1 commit into from
Mar 12, 2026
Merged

to_editor -> into_editor #12798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/but-rebase/src/graph_rebase/creation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ impl GraphExt for Graph {

impl SuccessfulRebase {
/// Converts a SuccessfulRebase back into another editor for multi-step operations
pub fn to_editor(self) -> Editor {
pub fn into_editor(self) -> Editor {
Editor {
graph: self.graph,
initial_references: self.initial_references,
Expand Down
2 changes: 1 addition & 1 deletion crates/but-workspace/src/commit/move_changes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pub(crate) mod function {
editor.replace(source_selector, Step::new_pick(new_source_commit_id))?;

// Rebase and get potentially rebased destination commit
let mut editor = editor.rebase()?.to_editor();
let mut editor = editor.rebase()?.into_editor();
let (_, rebased_destination_commit) =
editor.find_selectable_commit(destination_selector)?;
let destination_tree_id = {
Expand Down
Loading