fix: Tag event rules, fix broken runner hook examples #4378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winwinashwin
changed the title
Not all event rules were tagged. Add the tags to missing ones. Did a global search for "aws_cloudwatch_event_rule", Added tags to untagged event rules
Commit 2622589 disabled heredoc interpolation of runner hooks. Update the examples accordingly
winwinashwin
force-pushed
the
ashwin/tags
branch
from
4b81f82 to
b90e2c7
Compare
npalm
reviewed
Jan 24, 2025
npalm
approved these changes
Jan 27, 2025
npalm
pushed a commit
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [6.2.0](v6.1.3...v6.2.0) (2025-01-29) ### Features * Support GitHub Enterprise Cloud with Data Residency ([#4390](#4390)) ([02b4a04](02b4a04)) @neethu-p ### Bug Fixes * **lambda:** bump the aws group in /lambdas with 7 updates ([#4383](#4383)) ([1b3f8af](1b3f8af)) * Tag event rules, fix broken runner hook examples ([#4378](#4378)) ([6345ec2](6345ec2)) @winwinashwin --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com> Co-authored-by: github-aws-runners-pr|bot <github-aws-runners-pr[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4377
Resolves: #4333 (comment)