Skip to content

fix: Tag event rules, fix broken runner hook examples #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix: Tag event rules, fix broken runner hook examples #4378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b56d6d3
fix: Add tags to event rules
winwinashwin Jan 24, 2025
b90e2c7
fix: Avoid escaping `$` in example runner hooks
winwinashwin Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/multi-runner/templates/runner-configs/linux-arm64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ runner_config:
delay_webhook_event: 0
scale_down_schedule_expression: cron(* * * * ? *)
runner_hook_job_started: |
echo "Running pre job hook as \$(whoami)"
echo "Running pre job hook as $(whoami)"
runner_hook_job_completed: |
echo "Running post job hook as \$(whoami)"
echo "Running post job hook as $(whoami)"
1 change: 1 addition & 0 deletions modules/termination-watcher/notification/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module "termination_warning_watcher" {
resource "aws_cloudwatch_event_rule" "spot_instance_termination_warning" {
name = "${var.config.prefix != null ? format("%s-", var.config.prefix) : ""}spot-notify"
description = "Spot Instance Termination Warning"
tags = local.config.tags

event_pattern = <<EOF
{
Expand Down
1 change: 1 addition & 0 deletions modules/termination-watcher/termination/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module "termination_handler" {
resource "aws_cloudwatch_event_rule" "spot_instance_termination" {
name = "${var.config.prefix != null ? format("%s-", var.config.prefix) : ""}spot-termination"
description = "Spot Instance Termination (BidEventicedEvent)"
tags = local.config.tags

event_pattern = <<EOF
{
Expand Down
3 changes: 2 additions & 1 deletion modules/webhook/eventbridge/dispatcher.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
resource "aws_cloudwatch_event_rule" "workflow_job" {
name = "${var.config.prefix}-workflow_job"
description = "Workflow job event ruule for job queued."
description = "Workflow job event rule for job queued."
event_bus_name = aws_cloudwatch_event_bus.main.name
tags = var.config.tags

event_pattern = <<EOF
{
Expand Down
Loading