Skip to content

Potential fix for code scanning alert no. 1: Prototype-polluting assignment #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisreddington merged 2 commits into from
Jul 30, 2025
Merged

Potential fix for code scanning alert no. 1: Prototype-polluting assignment #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83a8003
Potential fix for code scanning alert no. 1: Prototype-polluting assi…
chrisreddington Jul 30, 2025
3f62515
Merge branch 'main' into alert-autofix-1
chrisreddington Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions shared/src/games/tic-tac-toe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,15 @@ export class TicTacToeGame implements Game<TicTacToeGameState, TicTacToeMove> {
return false;
}

// Check if the move is within bounds
if (row < 0 || row >= 3 || col < 0 || col >= 3) {
// Check that row and col are numbers, integers, and not special property names
if (
typeof row !== 'number' ||
typeof col !== 'number' ||
!Number.isInteger(row) ||
!Number.isInteger(col) ||
row < 0 || row >= 3 ||
col < 0 || col >= 3
) {
return false;
}

Expand Down