test: add missing Gemini API target test coverage to fix CI branch coverage regression by Copilot · Pull Request #1662 · github/gh-aw-firewall

Copilot · 2026-04-04T15:08:03Z

Summary

The Test Coverage Report CI workflow was failing because the Gemini API proxy feature (port 10003) added new branches in src/cli.ts that were not covered by tests, causing branch coverage to drop by -0.04% (from 78.50% to 78.46%), triggering the regression check.

Root Cause

Three branches in src/cli.ts introduced by the Gemini feature had zero test coverage:

Line 391 — if (geminiTargetWarning) in emitApiProxyTargetWarnings: the truthy case (a warning is emitted when a custom Gemini target is not in the allowed domains list) was never exercised.
Line 535 — if (options.geminiApiTarget) in resolveApiTargetsToAllowedDomains: the Gemini option flag branch was never tested.
Line 537 — else if (env['GEMINI_API_TARGET']) in resolveApiTargetsToAllowedDomains: the Gemini env-var fallback branch was never tested.

Changes

Added tests to src/cli.test.ts:

Import DEFAULT_GEMINI_API_TARGET and add it to the constants assertion
emitApiProxyTargetWarnings:
- Emits warning for custom Gemini target not in allowed domains
- Emits no warning when custom Gemini target is in allowed domains
- Uses default target (no warning) when geminiApiTarget is undefined
- Emits warnings for all four custom targets (OpenAI, Anthropic, Copilot, Gemini)
resolveApiTargetsToAllowedDomains:
- Adds geminiApiTarget option to allowed domains
- Falls back to GEMINI_API_TARGET env var when option not set
- Prefers option flag over env var

Results

All 1305 tests pass. Branch coverage improved from 78.45% → 78.56%, exceeding the base branch coverage of 78.50%.

Coverage comparison generated by scripts/ci/compare-coverage.ts

Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/0ed05562-3ddb-490f-9b6a-dd5cfa3bb0fc

Copilot

Pull request overview

Adds missing test coverage for the Gemini API target support in the CLI to prevent CI branch coverage regressions and ensure Gemini-specific branches are exercised.

Changes:

Extends CLI constant assertions to include DEFAULT_GEMINI_API_TARGET.
Adds emitApiProxyTargetWarnings tests covering Gemini warning/no-warning/default behavior.
Adds resolveApiTargetsToAllowedDomains tests covering Gemini flag and env-var fallback behavior.

Show a summary per file

File	Description
`src/cli.test.ts`	Adds Gemini-specific unit tests to cover previously untested branches in `emitApiProxyTargetWarnings` and `resolveApiTargetsToAllowedDomains`.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 1

Copilot · 2026-04-04T15:19:51Z

src/cli.test.ts

      expect(DEFAULT_ANTHROPIC_API_TARGET).toBe('api.anthropic.com');
      expect(DEFAULT_COPILOT_API_TARGET).toBe('api.githubcopilot.com');
+      expect(DEFAULT_GEMINI_API_TARGET).toBe('generativelanguage.googleapis.com');
    });


The describe block name is now misleading: it mentions only OpenAI/Anthropic, but the assertions also cover Copilot and Gemini defaults. Consider renaming the describe title to reflect all constants being validated (or a more generic 'DEFAULT_*_API_TARGET').

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-04-04T15:27:41Z

Smoke test results (run 23981761197)

Test	Result
GitHub MCP (last 2 merged PRs: #1641, #1654)	✅
Playwright (`github.com` title contains "GitHub")	✅
File write (`smoke-test-claude-23981761197.txt`)	✅
Bash verify (file contents confirmed)	✅

Overall: PASS

💥 [THE END] — Illustrated by Smoke Claude for issue #1662

github-actions · 2026-04-04T15:28:07Z

🔬 Smoke Test Results

Test	Status
GitHub MCP connectivity	✅
GitHub.com HTTP connectivity	⚠️ pre-step data unavailable
File write/read	⚠️ pre-step data unavailable

PR: "test: add missing Gemini API target test coverage to fix CI branch coverage regression"
Author: @Copilot | Assignees: @lpcox, @Copilot

Overall: PARTIAL — MCP ✅, but smoke-data step outputs were unresolved template variables ($\{\{ steps.smoke-data.outputs.* }}); HTTP and file tests inconclusive.

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-04-04T15:28:17Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	`Python 3.12.13`	`Python 3.12.3`	❌ NO
Node.js	`v24.14.1`	`v20.20.2`	❌ NO
Go	`go1.22.12`	`go1.22.12`	✅ YES

Result: ❌ Not all runtimes match — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot for issue #1662

github-actions · 2026-04-04T15:28:47Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #1662 · ◷

github-actions · 2026-04-04T15:28:59Z

Smoke test results:

[docs] docs: sync smoke-claude toolset and max-turns after token optimization
test: add tests for Gemini API proxy support to fix coverage regression
GitHub MCP Testing: ✅
Safe Inputs GH CLI Testing: ❌
Playwright Testing: ❌
Tavily Web Search Testing: ❌
File Writing + Bash cat: ✅
Discussion Interaction: ❌
Build AWF: ✅
Overall status: FAIL

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-04-04T15:29:10Z

Smoke Test: GitHub Actions Services Connectivity ✅

All checks passed:

Check	Result
Redis PING (`host.docker.internal:6379`)	✅ `PONG`
PostgreSQL `pg_isready` (`host.docker.internal:5432`)	✅ accepting connections
PostgreSQL `SELECT 1` (db: `smoketest`, user: `postgres`)	✅ returned `1`

🔌 Service connectivity validated by Smoke Services

* feat: add Google Gemini API proxy support (port 10003) Add full Gemini API proxy support to the AWF api-proxy sidecar, matching the pattern of existing OpenAI, Anthropic, and Copilot providers. This enables Gemini CLI to work inside the AWF sandbox without requiring workarounds in gh-aw. Changes: - Add GEMINI port 10003 to API_PROXY_PORTS - Add geminiApiKey, geminiApiTarget, geminiApiBasePath to WrapperConfig - Add --gemini-api-target and --gemini-api-base-path CLI flags - Add GEMINI_API_KEY to excluded env vars when api-proxy is enabled - Set placeholder GEMINI_API_KEY in agent container (Gemini CLI v0.65.0+ exits 41 without auth when GEMINI_API_BASE_URL is set) - Set GEMINI_API_BASE_URL pointing to sidecar in agent env - Add .gemini to whitelisted home subdirectories (bind mount + chroot) - Add Gemini proxy server in server.js using x-goog-api-key header - Expose port 10003 in Dockerfile Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: add tests for Gemini API proxy support in docker-manager (#1654) Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/03ba1344-8f2e-4d67-890f-46e665522db4 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * test: add missing Gemini API target test coverage to fix CI branch coverage regression (#1662) * test: add missing Gemini API target test coverage in cli.test.ts Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/0ed05562-3ddb-490f-9b6a-dd5cfa3bb0fc * fix: rename describe block to reflect all API target constants Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Landon Cox <landon.cox@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

test: add missing Gemini API target test coverage in cli.test.ts

d882a2d

Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/0ed05562-3ddb-490f-9b6a-dd5cfa3bb0fc

Copilot AI assigned Copilot and lpcox Apr 4, 2026

Copilot created this pull request from a session on behalf of lpcox April 4, 2026 15:08 View session

Copilot AI requested a review from lpcox April 4, 2026 15:08

Copilot finished work on behalf of lpcox April 4, 2026 15:08

github-actions bot added the smoke-copilot label Apr 4, 2026

This comment has been minimized.

Sign in to view

github-actions bot added the build-test label Apr 4, 2026

This comment has been minimized.

Sign in to view

github-actions bot added the smoke-services label Apr 4, 2026

github-actions bot mentioned this pull request Apr 4, 2026

[aw] Smoke Codex failed #1663

Closed

lpcox marked this pull request as ready for review April 4, 2026 15:17

lpcox requested a review from Mossaka as a code owner April 4, 2026 15:17

Copilot AI review requested due to automatic review settings April 4, 2026 15:17

Copilot started reviewing on behalf of lpcox April 4, 2026 15:18 View session

Copilot AI reviewed Apr 4, 2026

View reviewed changes

fix: rename describe block to reflect all API target constants

d6dea60

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions bot mentioned this pull request Apr 4, 2026

[agentics] No-Op Runs #1630

Open

github-actions bot added the smoke-claude label Apr 4, 2026

lpcox merged commit 17d9395 into feat/gemini-api-proxy-support Apr 4, 2026
36 of 37 checks passed

lpcox deleted the copilot/fix-github-actions-workflow-a6630634-59cd-4e93-8792-c601f8fdcf45 branch April 4, 2026 15:30

This was referenced Apr 4, 2026

feat: add Google Gemini API proxy support (port 10003) #1640

Merged

⚡ Optimize secret-digger-copilot: remove unused tools, condense prompt, add emergency exit rule #1661

Merged

This was referenced Apr 5, 2026

[aw] No-Op Runs #1668

Open

⚡ pelis-agent-factory-advisor: remove unused GitHub toolset, pre-fetch docs #1680

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add missing Gemini API target test coverage to fix CI branch coverage regression#1662

test: add missing Gemini API target test coverage to fix CI branch coverage regression#1662
lpcox merged 2 commits intofeat/gemini-api-proxy-supportfrom
copilot/fix-github-actions-workflow-a6630634-59cd-4e93-8792-c601f8fdcf45

Copilot AI commented Apr 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Uh oh!

Copilot AI Apr 4, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 4, 2026

Summary

Root Cause

Changes

Results

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

🔬 Smoke Test Results

Uh oh!

github-actions bot commented Apr 4, 2026

Chroot Version Comparison Results

Uh oh!

github-actions bot commented Apr 4, 2026

🏗️ Build Test Suite Results

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

Smoke Test: GitHub Actions Services Connectivity ✅

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants