Skip to content

Conversation

sergiolms
Copy link
Contributor

@sergiolms sergiolms commented Sep 24, 2024

Description

E2E tests were giving the following error:
Captura de pantalla 2024-09-24 a las 13 25 23

This is caused because Playwright requires that parameter to be a destructured object, but our eslint rules collide with that because we don't allow empty patterns. The solution is to ignore that eslint line for this case.

In addition, I set the maximum timeout from 5s to 10s, as in some cases if VSCode takes too long to load, the test would timeout before even starting GitLens.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergiolms sergiolms self-assigned this Sep 24, 2024
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sergiolms sergiolms merged commit 3077ecc into main Sep 24, 2024
3 checks passed
@sergiolms sergiolms deleted the other/fix_e2e_tests branch September 24, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants