Skip to content

Conversation

d13
Copy link
Member

@d13 d13 commented Dec 3, 2024

  • improves glicons build:
    • generates icon map of characters for use in web components and sass
  • improves codicons build:
    • generates icon map of characters for use in web components and scss
    • uses new map to generate CSS selectors
  • adds scss mixins to create custom selectors for icons
  • removes duplicate codicon SVGs from glicons
  • removes glicons and codicons SCSS imports from the Commit Graph (~34k)

@d13 d13 self-assigned this Dec 3, 2024
@d13 d13 added the debt Technical debt label Dec 3, 2024
@d13 d13 marked this pull request as ready for review December 3, 2024 23:48
@d13 d13 force-pushed the feature/icons-generation branch 2 times, most recently from 2aca2ec to 34d326d Compare December 4, 2024 00:14
@eamodio eamodio requested a review from Copilot December 4, 2024 19:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 31 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • .prettierignore: Language not supported
  • images/icons/template/component-map.hbs: Language not supported
  • images/icons/template/mapping.json: Language not supported
  • images/icons/template/sass-map.hbs: Language not supported
  • package.json: Language not supported
  • src/webviews/apps/plus/graph/graph.scss: Language not supported
  • src/webviews/apps/shared/glicons.scss: Language not supported
  • src/webviews/apps/shared/styles/icons/glicons-map.scss: Language not supported
  • src/webviews/apps/plus/graph/actions/fetchButton.tsx: Evaluated as low risk
  • src/webviews/apps/commitDetails/components/gl-wip-details.ts: Evaluated as low risk
  • src/webviews/apps/plus/home/components/active-work.ts: Evaluated as low risk
  • src/webviews/apps/commitDetails/components/gl-status-nav.ts: Evaluated as low risk
  • src/webviews/apps/plus/graph/actions/pushPullButton.tsx: Evaluated as low risk
  • src/commands/quickCommand.buttons.ts: Evaluated as low risk
  • src/webviews/apps/plus/home/components/branch-section.ts: Evaluated as low risk
Comments skipped due to low confidence (3)

src/webviews/apps/plus/graph/GraphWrapper.tsx:1247

  • [nitpick] The icon name 'custom-start-work' might be incorrect. Verify if it should be 'custom-git-branch-create'.
<CodeIcon className="action-button__icon" icon="custom-start-work" />

src/webviews/apps/plus/graph/GraphWrapper.tsx:1190

  • [nitpick] The icon name 'gl-worktrees-view' might be incorrect. Verify if it should be 'glicon-repositories-view'.
<CodeIcon icon="gl-worktrees-view" aria-hidden="true" />

src/webviews/apps/plus/graph/GraphWrapper.tsx:1321

  • [nitpick] Ensure that the conditional icon name 'filter${hasFilters ? '-filled' : ''}' is correct and matches the original intent.
<CodeIcon icon={`filter${hasFilters ? '-filled' : ''}`} />

@d13 d13 force-pushed the feature/icons-generation branch from 34d326d to bf30259 Compare December 5, 2024 02:18
@d13 d13 merged commit bf30259 into main Dec 5, 2024
2 of 3 checks passed
@d13 d13 deleted the feature/icons-generation branch December 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant