Skip to content

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jan 15, 2025

(#3923)

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb linked an issue Jan 15, 2025 that may be closed by this pull request
sergeibbb added a commit that referenced this pull request Jan 15, 2025
@sergeibbb sergeibbb force-pushed the 3923-ghe-in-launchpad branch from 1f353a5 to df482fe Compare January 15, 2025 22:53
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge, just one nitpick regarding typing

@sergeibbb sergeibbb force-pushed the 3923-ghe-in-launchpad branch from df482fe to ea55d1b Compare January 16, 2025 00:03
-Prevents lack of GHE from breaking Launchpad query
-Fixes labels for GHE
@sergeibbb sergeibbb merged commit f884fc6 into main Jan 16, 2025
3 checks passed
@sergeibbb sergeibbb deleted the 3923-ghe-in-launchpad branch January 16, 2025 01:15
@sergeibbb sergeibbb mentioned this pull request Mar 5, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support GitHub Enterprise (GKDev) in Launchpad

2 participants