Fixes path splitting logic in BitbucketServerRemote #4056
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeibbb
commented
Mar 3, 2025
|
|
||
| protected override splitPath(): [string, string] { | ||
| if (this.path.startsWith('scm/')) { | ||
| const path = this.path.replace('scm/', ''); |
There was a problem hiding this comment.
@ericf-axosoft , @axosoft-ramint
const path = this.path.replace('scm/', '');
The biggest problem here is if project name is scm. Can I assume that normally repo path can be either org/repo, where repo part cannot contain slashes?
I'm trying to create a repo name with slashes and Bitbucket replaces it with dashes:
Therefore I can check if the path is started with scm/ and look for the second /. If the second / does not exist, then scm is just a project name.
Agree?
sergeibbb
force-pushed
the
bug/3218-bitbucket-scm-in-path-fix
branch
from
f292bd0 to
ed339b4
Compare
sergeibbb
force-pushed
the
bug/3218-bitbucket-scm-in-path-fix
branch
from
ed339b4 to
0dcd852
Compare
eamodio
approved these changes
Mar 5, 2025
sergeibbb
force-pushed
the
bug/3218-bitbucket-scm-in-path-fix
branch
from
0dcd852 to
6b06bd3
Compare
saeedzaha
pushed a commit
to saeedzaha/vscode-gitlens
that referenced
this pull request
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #3218
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses