Skip to content

Fix linter #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix linter #4639

wants to merge 2 commits into from
+6 −2

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Oct 1, 2025 •
edited
Loading

Description

Fixes #4638

  • Fixes linter that fails in main
  • Takes measures to avoid this in future

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

sergeibbb added a commit that referenced this pull request Oct 1, 2025
@sergeibbb
Adds lint step to unit test script
d0de36c 
(#4638, #4639)
sergeibbb added a commit that referenced this pull request Oct 1, 2025
@sergeibbb
Fixes linter failing by disabling @ts/await-thenable rule for mixed s…
ead9811 
…ync/async patterns

Turns off the problematic await-thenable ESLint rule to accommodate
common usage of Promise aggregation with mixed synchronous and
asynchronous values, preventing unnecessary code complexity.
Also removes outdated inline disables for to-string lint warnings.

(#4638, #4639)
@sergeibbb sergeibbb requested a review from eamodio October 1, 2025 08:59
@sergeibbb
Adds lint step to unit test script
f7a716c 
(#4638, #4639)
@sergeibbb
Fixes linter failing by disabling @ts/await-thenable rule for mixed s…
131dc74 
…ync/async patterns

Turns off the problematic await-thenable ESLint rule to accommodate
common usage of Promise aggregation with mixed synchronous and
asynchronous values, preventing unnecessary code complexity.
Also removes outdated inline disables for to-string lint warnings.

(#4638, #4639)
@eamodio
Copy link
Member

eamodio commented Oct 2, 2025

Closing, since I fixed the few issues directly in 2380da9

And it looks like they will be relaxing the rule for most of those ignored cases shortly:
typescript-eslint/typescript-eslint#11609

@eamodio eamodio closed this Oct 2, 2025
@sergeibbb sergeibbb deleted the fix-linter branch October 2, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eamodio eamodio Awaiting requested review from eamodio

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix linter

2 participants

@sergeibbb @eamodio