Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@ export default ts.config(
],

// TypeScript rules

// @typescript-eslint/await-thenable is disabled because Promise.allSettled/all with mixed thenable/non-thenable arrays
// is a valid pattern used throughout the codebase for handling mixed sync/async operations safely.
// The new stricter rule would require unnecessary complexity to separate sync/async values before Promise aggregation.
'@typescript-eslint/await-thenable': 'off',
'@typescript-eslint/consistent-type-assertions': [
'error',
{ assertionStyle: 'as', objectLiteralTypeAssertions: 'allow-as-parameter' },
Expand Down
2 changes: 0 additions & 2 deletions src/plus/ai/aiProviderService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1708,7 +1708,6 @@ export class AIProviderService implements Disposable {
setLogScopeExit(
scope,
`model: ${model.provider.id}/${model.id}`,
// eslint-disable-next-line @typescript-eslint/no-base-to-string
`failed: ${String(ex)} (${String(ex.original)})`,
);

Expand All @@ -1718,7 +1717,6 @@ export class AIProviderService implements Disposable {
...telementry.data,
duration: Date.now() - start,
failed: true,
// eslint-disable-next-line @typescript-eslint/no-base-to-string
'failed.error': String(ex),
'failed.error.detail': String(ex.original),
},
Expand Down
1 change: 1 addition & 0 deletions tests/docker/run-unit-tests.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
(
set -e
pnpm run pretty:check
pnpm run lint
pnpm run test
);
EXIT_CODE=$?;
Expand Down