-
Notifications
You must be signed in to change notification settings - Fork 1.3k
JetBrains IDEs 2024.3 stable release
#20370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca7f3a5 to
1221cd9
Compare
| - NO_VERIFY_JB_PLUGIN=true | ||
| config: | ||
| commands: | ||
| - ["rm", "-rf", "src/main/kotlin/io/gitpod/jetbrains/remote/GitpodMetricControlProvider.kt"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To unblock rider plugin build
| return image.replace("gitpod-dev-artifact", "gitpod-core-dev"); | ||
| for (const imgFromMain of imagesBuildFromMain) { | ||
| if (image.includes(imgFromMain)) { | ||
| return image.replace("gitpod-dev-artifact", "gitpod-core-dev"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure we could use these images built from main in preview env, repository is set by installer, we correct it in this patch script
gitpod-dev-artifact- dev imagesgitpod-core-dev- prod images from main
| "image": "{{.Repository}}/ide/clion:{{.WorkspaceVersions.Workspace.DesktopIdeImages.CLionImage.Version}}", | ||
| "latestImage": "{{.ResolvedJBImageLatest.CLion}}", | ||
| "pluginImage": "{{.JetBrainsPluginImage}}", | ||
| "pluginImage": "{{.JetBrainsPluginImagePrevious}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLion and RustRover 2024.3 are not release yet, we need to force them to use old backend plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rider is a special one, we don't take care of it for a long time already, (it had a bug before that we can't build, and the bug was fixed, but we don't have time to work on it)
| } | ||
|
|
||
| // {{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6 | ||
| previousStableJetBrainsBackendPluginVersion := "commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value is a copy current stable backend plugin image from main build
544148d to
9622ed1
Compare
|
/unhold |
Description
Related Issue(s)
Fixes CLC-941
How to test
✅ Smoke test
2024.32024.32024.2✅ Integration tests should pass
https://github.com/gitpod-io/gitpod/actions/runs/11859552844/job/33053613264?pr=20370
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold