Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions WORKSPACE.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ defaultArgs:
codeWebExtensionCommit: 7ff72a2938a7a06cbdf3964590f7e9b7525958f3
xtermCommit: d547d4ff4590b66c3ea24342fc62e3afcf6b77bc
noVerifyJBPlugin: false
intellijDownloadUrl: "https://download.jetbrains.com/idea/ideaIU-2024.2.4.tar.gz"
golandDownloadUrl: "https://download.jetbrains.com/go/goland-2024.2.3.tar.gz"
pycharmDownloadUrl: "https://download.jetbrains.com/python/pycharm-professional-2024.2.4.tar.gz"
phpstormDownloadUrl: "https://download.jetbrains.com/webide/PhpStorm-2024.2.4.tar.gz"
rubymineDownloadUrl: "https://download.jetbrains.com/ruby/RubyMine-2024.2.4.tar.gz"
webstormDownloadUrl: "https://download.jetbrains.com/webstorm/WebStorm-2024.2.4.tar.gz"
intellijDownloadUrl: "https://download.jetbrains.com/idea/ideaIU-2024.3.tar.gz"
golandDownloadUrl: "https://download.jetbrains.com/go/goland-2024.3.tar.gz"
pycharmDownloadUrl: "https://download.jetbrains.com/python/pycharm-professional-2024.3.tar.gz"
phpstormDownloadUrl: "https://download.jetbrains.com/webide/PhpStorm-2024.3.tar.gz"
rubymineDownloadUrl: "https://download.jetbrains.com/ruby/RubyMine-2024.3.tar.gz"
webstormDownloadUrl: "https://download.jetbrains.com/webstorm/WebStorm-2024.3.tar.gz"
riderDownloadUrl: "https://download.jetbrains.com/rider/JetBrains.Rider-2024.1.4.tar.gz"
clionDownloadUrl: "https://download.jetbrains.com/cpp/CLion-2024.2.3.tar.gz"
rustroverDownloadUrl: "https://download.jetbrains.com/rustrover/RustRover-2024.2.5.tar.gz"
Expand Down
2 changes: 2 additions & 0 deletions components/ide/jetbrains/backend-plugin/BUILD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ packages:
- NO_VERIFY_JB_PLUGIN=true
config:
commands:
- ["rm", "-rf", "src/main/kotlin/io/gitpod/jetbrains/remote/GitpodMetricControlProvider.kt"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To unblock rider plugin build

- ["mv", "build.gradle-stable.kts", "build.gradle.kts"]
- ["./build.sh", "${__git_commit}"]
- name: plugin-latest-rider
Expand Down Expand Up @@ -182,6 +183,7 @@ packages:
- SDKMAN_DIR=/home/gitpod/.sdkman
config:
commands:
- ["rm", "-rf", "src/main/kotlin/io/gitpod/jetbrains/remote/GitpodMetricControlProvider.kt"]
# TODO(hw): remove after 2024.2.* is stable
- ["mv", "build.gradle-latest.kts", "build.gradle.kts"]
- - "bash"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
# See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
# for insight into build numbers and IntelliJ Platform versions.
# revert pluginSinceBuild if it's unnecessary
pluginSinceBuild=242.22855
pluginUntilBuild=242.*
pluginSinceBuild=243.21565
pluginUntilBuild=243.*
# Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
# See https://jb.gg/intellij-platform-builds-list for available build versions.
pluginVerifierIdeVersions=2024.2
pluginVerifierIdeVersions=2024.3
# Version from "com.jetbrains.intellij.idea" which can be found at https://www.jetbrains.com/intellij-repository/snapshots
platformVersion=242.22855-EAP-CANDIDATE-SNAPSHOT
platformVersion=243.21565-EAP-CANDIDATE-SNAPSHOT
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the GNU Affero General Public License (AGPL).
// See License.AGPL.txt in the project root for license information.

package io.gitpod.jetbrains.remote.latest
package io.gitpod.jetbrains.remote

import com.jetbrains.ide.model.uiautomation.BeControl
import com.jetbrains.ide.model.uiautomation.DefiniteProgress
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the GNU Affero General Public License (AGPL).
// See License.AGPL.txt in the project root for license information.

package io.gitpod.jetbrains.remote.latest
package io.gitpod.jetbrains.remote

import com.jetbrains.rd.util.lifetime.Lifetime
import com.jetbrains.rd.util.threading.coroutines.launch
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,5 @@
<!--suppress PluginXmlValidity -->
<idea-plugin>
<extensions defaultExtensionNs="com.intellij">
<applicationService serviceInterface="io.gitpod.jetbrains.remote.GitpodPortForwardingService"
serviceImplementation="io.gitpod.jetbrains.remote.latest.GitpodPortForwardingServiceImpl"
client="controller" preload="true"/>
<gateway.customization.performance id="gitpodMetricsControl" order="before cpuControl"
implementation="io.gitpod.jetbrains.remote.latest.GitpodMetricControlProvider"/>
</extensions>
</idea-plugin>
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,5 @@
<!--suppress PluginXmlValidity -->
<idea-plugin>
<extensions defaultExtensionNs="com.intellij">
<applicationService serviceInterface="io.gitpod.jetbrains.remote.GitpodPortForwardingService"
serviceImplementation="io.gitpod.jetbrains.remote.stable.GitpodPortForwardingServiceImpl"
client="controller" preload="true"/>
<gateway.customization.performance id="gitpodMetricsControl" order="before cpuControl"
implementation="io.gitpod.jetbrains.remote.stable.GitpodMetricControlProvider"/>
</extensions>
</idea-plugin>
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@
<applicationService serviceInterface="io.gitpod.jetbrains.remote.GitpodIgnoredPortsForNotificationService"
serviceImplementation="io.gitpod.jetbrains.remote.internal.GitpodIgnoredPortsForNotificationServiceImpl"
preload="true"/>


<applicationService serviceInterface="io.gitpod.jetbrains.remote.GitpodPortForwardingService"
serviceImplementation="io.gitpod.jetbrains.remote.GitpodPortForwardingServiceImpl"
client="controller" preload="true"/>
<gateway.customization.performance id="gitpodMetricsControl" order="before cpuControl"
implementation="io.gitpod.jetbrains.remote.GitpodMetricControlProvider"/>
</extensions>

<actions>
Expand Down
13 changes: 10 additions & 3 deletions dev/preview/workflow/preview/patch-ide-configmap.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,17 @@ function replaceImage(image) {
return image.replace("gitpod-dev-artifact", "gitpod-core-dev");
}

const imagesBuildFromMain = [
"jb-backend-plugin:commit-2d67254d5aa110bc2c76cd807b85b272e3d54d97-latest",
"jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
];

// TODO(hw): remove me
function replaceImage2(image) {
if (image.includes("jb-backend-plugin:commit-2d67254d5aa110bc2c76cd807b85b272e3d54d97-latest")) {
return image.replace("gitpod-dev-artifact", "gitpod-core-dev");
for (const imgFromMain of imagesBuildFromMain) {
if (image.includes(imgFromMain)) {
return image.replace("gitpod-dev-artifact", "gitpod-core-dev");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure we could use these images built from main in preview env, repository is set by installer, we correct it in this patch script

  • gitpod-dev-artifact - dev images
  • gitpod-core-dev - prod images from main

}
}
return image;
}
Expand All @@ -31,7 +38,7 @@ for (let ide in json.ideOptions.options) {
}

// TODO(hw): remove me
if (["intellij"].includes(ide)) {
if (["intellij", "clion", "rustrover"].includes(ide)) {
json.ideOptions.options[ide].pluginImage = replaceImage2(json.ideOptions.options[ide].pluginImage);
json.ideOptions.options[ide].imageLayers = json.ideOptions.options[ide].imageLayers.map(replaceImage2);
}
Expand Down
56 changes: 52 additions & 4 deletions install/installer/pkg/components/ide-service/ide-configmap.json
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,14 @@
],
"allowPin": true,
"versions": [
{
"version": "2024.2.4",
"image": "{{.Repository}}/ide/intellij:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"imageLayers": [
"{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6"
]
},
{
"version": "2024.2.3",
"image": "{{.Repository}}/ide/intellij:commit-c0c9b747905872fcade355a5347e4de98711a0a0",
Expand Down Expand Up @@ -307,6 +315,14 @@
],
"allowPin": true,
"versions": [
{
"version": "2024.2.3",
"image": "{{.Repository}}/ide/goland:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"imageLayers": [
"{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6"
]
},
{
"version": "2024.2.2",
"image": "{{.Repository}}/ide/goland:commit-2aba460a50c43e830b015a6ff4e52e6491a3ed36",
Expand Down Expand Up @@ -401,6 +417,14 @@
],
"allowPin": true,
"versions": [
{
"version": "2024.2.4",
"image": "{{.Repository}}/ide/pycharm:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"imageLayers": [
"{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6"
]
},
{
"version": "2024.2.3",
"image": "{{.Repository}}/ide/pycharm:commit-c0c9b747905872fcade355a5347e4de98711a0a0",
Expand Down Expand Up @@ -494,6 +518,14 @@
],
"allowPin": true,
"versions": [
{
"version": "2024.2.4",
"image": "{{.Repository}}/ide/phpstorm:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"imageLayers": [
"{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6"
]
},
{
"version": "2024.2.3",
"image": "{{.Repository}}/ide/phpstorm:commit-c0c9b747905872fcade355a5347e4de98711a0a0",
Expand Down Expand Up @@ -579,6 +611,14 @@
],
"allowPin": true,
"versions": [
{
"version": "2024.2.4",
"image": "{{.Repository}}/ide/rubymine:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"imageLayers": [
"{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6"
]
},
{
"version": "2024.2.3",
"image": "{{.Repository}}/ide/rubymine:commit-c0c9b747905872fcade355a5347e4de98711a0a0",
Expand Down Expand Up @@ -672,6 +712,14 @@
],
"allowPin": true,
"versions": [
{
"version": "2024.2.4",
"image": "{{.Repository}}/ide/webstorm:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"imageLayers": [
"{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6",
"{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6"
]
},
{
"version": "2024.2.3",
"image": "{{.Repository}}/ide/webstorm:commit-c0c9b747905872fcade355a5347e4de98711a0a0",
Expand Down Expand Up @@ -814,10 +862,10 @@
"logo": "{{.IdeLogoBase}}/clionLogo.svg",
"image": "{{.Repository}}/ide/clion:{{.WorkspaceVersions.Workspace.DesktopIdeImages.CLionImage.Version}}",
"latestImage": "{{.ResolvedJBImageLatest.CLion}}",
"pluginImage": "{{.JetBrainsPluginImage}}",
"pluginImage": "{{.JetBrainsPluginImagePrevious}}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLion and RustRover 2024.3 are not release yet, we need to force them to use old backend plugin

Copy link
Contributor Author

@mustard-mh mustard-mh Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rider is a special one, we don't take care of it for a long time already, (it had a bug before that we can't build, and the bug was fixed, but we don't have time to work on it)

"pluginLatestImage": "{{.JetBrainsPluginLatestImage}}",
"imageLayers": [
"{{.JetBrainsPluginImage}}",
"{{.JetBrainsPluginImagePrevious}}",
"{{.JetBrainsLauncherImage}}"
],
"latestImageLayers": [
Expand Down Expand Up @@ -891,10 +939,10 @@
"logo": "{{.IdeLogoBase}}/rustroverLogo.svg",
"image": "{{.Repository}}/ide/rustrover:{{.WorkspaceVersions.Workspace.DesktopIdeImages.RustRoverImage.Version}}",
"latestImage": "{{.ResolvedJBImageLatest.RustRover}}",
"pluginImage": "{{.JetBrainsPluginImage}}",
"pluginImage": "{{.JetBrainsPluginImagePrevious}}",
"pluginLatestImage": "{{.JetBrainsPluginLatestImage}}",
"imageLayers": [
"{{.JetBrainsPluginImage}}",
"{{.JetBrainsPluginImagePrevious}}",
"{{.JetBrainsLauncherImage}}"
],
"latestImageLayers": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ func GenerateIDEConfigmap(ctx *common.RenderContext) (*ide_config.IDEConfig, err
CodeWebExtensionImage string

JetBrainsPluginImage string
JetBrainsPluginImagePrevious string
JetBrainsPluginLatestImage string
JetBrainsPluginRiderImage string
JetBrainsPluginLatestRiderImage string
Expand All @@ -67,6 +68,9 @@ func GenerateIDEConfigmap(ctx *common.RenderContext) (*ide_config.IDEConfig, err
WorkspaceVersions versions.Components
}

// {{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6
previousStableJetBrainsBackendPluginVersion := "commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value is a copy current stable backend plugin image from main build


configTmpl := ConfigTemplate{
Repository: ctx.Config.Repository,
IdeLogoBase: fmt.Sprintf("https://ide.%s/image/ide-logo", ctx.Config.Domain),
Expand All @@ -76,6 +80,7 @@ func GenerateIDEConfigmap(ctx *common.RenderContext) (*ide_config.IDEConfig, err
CodeWebExtensionImage: ctx.ImageName(ctx.Config.Repository, ide.CodeWebExtensionImage, ctx.VersionManifest.Components.Workspace.CodeWebExtensionImage.Version),

JetBrainsPluginImage: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.JetBrainsBackendPluginImage.Version),
JetBrainsPluginImagePrevious: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, previousStableJetBrainsBackendPluginVersion),
JetBrainsPluginLatestImage: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.JetBrainsBackendPluginLatestImage.Version),
JetBrainsPluginRiderImage: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.JetBrainsBackendPluginRiderImage.Version),
JetBrainsPluginLatestRiderImage: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.JetBrainsBackendPluginLatestRiderImage.Version),
Expand Down
Loading