-
Notifications
You must be signed in to change notification settings - Fork 1.3k
JetBrains IDEs 2024.3 stable release
#20370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
59cdfd9
b2019e0
87775d3
2a25b3d
1221cd9
9622ed1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,10 +9,17 @@ function replaceImage(image) { | |
| return image.replace("gitpod-dev-artifact", "gitpod-core-dev"); | ||
| } | ||
|
|
||
| const imagesBuildFromMain = [ | ||
| "jb-backend-plugin:commit-2d67254d5aa110bc2c76cd807b85b272e3d54d97-latest", | ||
| "jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| ]; | ||
|
|
||
| // TODO(hw): remove me | ||
| function replaceImage2(image) { | ||
| if (image.includes("jb-backend-plugin:commit-2d67254d5aa110bc2c76cd807b85b272e3d54d97-latest")) { | ||
| return image.replace("gitpod-dev-artifact", "gitpod-core-dev"); | ||
| for (const imgFromMain of imagesBuildFromMain) { | ||
| if (image.includes(imgFromMain)) { | ||
| return image.replace("gitpod-dev-artifact", "gitpod-core-dev"); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make sure we could use these images built from main in preview env, repository is set by installer, we correct it in this patch script
|
||
| } | ||
| } | ||
| return image; | ||
| } | ||
|
|
@@ -31,7 +38,7 @@ for (let ide in json.ideOptions.options) { | |
| } | ||
|
|
||
| // TODO(hw): remove me | ||
| if (["intellij"].includes(ide)) { | ||
| if (["intellij", "clion", "rustrover"].includes(ide)) { | ||
| json.ideOptions.options[ide].pluginImage = replaceImage2(json.ideOptions.options[ide].pluginImage); | ||
| json.ideOptions.options[ide].imageLayers = json.ideOptions.options[ide].imageLayers.map(replaceImage2); | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -206,6 +206,14 @@ | |
| ], | ||
| "allowPin": true, | ||
| "versions": [ | ||
| { | ||
| "version": "2024.2.4", | ||
| "image": "{{.Repository}}/ide/intellij:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "imageLayers": [ | ||
| "{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6" | ||
| ] | ||
| }, | ||
| { | ||
| "version": "2024.2.3", | ||
| "image": "{{.Repository}}/ide/intellij:commit-c0c9b747905872fcade355a5347e4de98711a0a0", | ||
|
|
@@ -307,6 +315,14 @@ | |
| ], | ||
| "allowPin": true, | ||
| "versions": [ | ||
| { | ||
| "version": "2024.2.3", | ||
| "image": "{{.Repository}}/ide/goland:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "imageLayers": [ | ||
| "{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6" | ||
| ] | ||
| }, | ||
| { | ||
| "version": "2024.2.2", | ||
| "image": "{{.Repository}}/ide/goland:commit-2aba460a50c43e830b015a6ff4e52e6491a3ed36", | ||
|
|
@@ -401,6 +417,14 @@ | |
| ], | ||
| "allowPin": true, | ||
| "versions": [ | ||
| { | ||
| "version": "2024.2.4", | ||
| "image": "{{.Repository}}/ide/pycharm:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "imageLayers": [ | ||
| "{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6" | ||
| ] | ||
| }, | ||
| { | ||
| "version": "2024.2.3", | ||
| "image": "{{.Repository}}/ide/pycharm:commit-c0c9b747905872fcade355a5347e4de98711a0a0", | ||
|
|
@@ -494,6 +518,14 @@ | |
| ], | ||
| "allowPin": true, | ||
| "versions": [ | ||
| { | ||
| "version": "2024.2.4", | ||
| "image": "{{.Repository}}/ide/phpstorm:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "imageLayers": [ | ||
| "{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6" | ||
| ] | ||
| }, | ||
| { | ||
| "version": "2024.2.3", | ||
| "image": "{{.Repository}}/ide/phpstorm:commit-c0c9b747905872fcade355a5347e4de98711a0a0", | ||
|
|
@@ -579,6 +611,14 @@ | |
| ], | ||
| "allowPin": true, | ||
| "versions": [ | ||
| { | ||
| "version": "2024.2.4", | ||
| "image": "{{.Repository}}/ide/rubymine:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "imageLayers": [ | ||
| "{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6" | ||
| ] | ||
| }, | ||
| { | ||
| "version": "2024.2.3", | ||
| "image": "{{.Repository}}/ide/rubymine:commit-c0c9b747905872fcade355a5347e4de98711a0a0", | ||
|
|
@@ -672,6 +712,14 @@ | |
| ], | ||
| "allowPin": true, | ||
| "versions": [ | ||
| { | ||
| "version": "2024.2.4", | ||
| "image": "{{.Repository}}/ide/webstorm:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "imageLayers": [ | ||
| "{{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6", | ||
| "{{.Repository}}/ide/jb-launcher:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6" | ||
| ] | ||
| }, | ||
| { | ||
| "version": "2024.2.3", | ||
| "image": "{{.Repository}}/ide/webstorm:commit-c0c9b747905872fcade355a5347e4de98711a0a0", | ||
|
|
@@ -814,10 +862,10 @@ | |
| "logo": "{{.IdeLogoBase}}/clionLogo.svg", | ||
| "image": "{{.Repository}}/ide/clion:{{.WorkspaceVersions.Workspace.DesktopIdeImages.CLionImage.Version}}", | ||
| "latestImage": "{{.ResolvedJBImageLatest.CLion}}", | ||
| "pluginImage": "{{.JetBrainsPluginImage}}", | ||
| "pluginImage": "{{.JetBrainsPluginImagePrevious}}", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| "pluginLatestImage": "{{.JetBrainsPluginLatestImage}}", | ||
| "imageLayers": [ | ||
| "{{.JetBrainsPluginImage}}", | ||
| "{{.JetBrainsPluginImagePrevious}}", | ||
| "{{.JetBrainsLauncherImage}}" | ||
| ], | ||
| "latestImageLayers": [ | ||
|
|
@@ -891,10 +939,10 @@ | |
| "logo": "{{.IdeLogoBase}}/rustroverLogo.svg", | ||
| "image": "{{.Repository}}/ide/rustrover:{{.WorkspaceVersions.Workspace.DesktopIdeImages.RustRoverImage.Version}}", | ||
| "latestImage": "{{.ResolvedJBImageLatest.RustRover}}", | ||
| "pluginImage": "{{.JetBrainsPluginImage}}", | ||
| "pluginImage": "{{.JetBrainsPluginImagePrevious}}", | ||
| "pluginLatestImage": "{{.JetBrainsPluginLatestImage}}", | ||
| "imageLayers": [ | ||
| "{{.JetBrainsPluginImage}}", | ||
| "{{.JetBrainsPluginImagePrevious}}", | ||
| "{{.JetBrainsLauncherImage}}" | ||
| ], | ||
| "latestImageLayers": [ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,6 +58,7 @@ func GenerateIDEConfigmap(ctx *common.RenderContext) (*ide_config.IDEConfig, err | |
| CodeWebExtensionImage string | ||
|
|
||
| JetBrainsPluginImage string | ||
| JetBrainsPluginImagePrevious string | ||
| JetBrainsPluginLatestImage string | ||
| JetBrainsPluginRiderImage string | ||
| JetBrainsPluginLatestRiderImage string | ||
|
|
@@ -67,6 +68,9 @@ func GenerateIDEConfigmap(ctx *common.RenderContext) (*ide_config.IDEConfig, err | |
| WorkspaceVersions versions.Components | ||
| } | ||
|
|
||
| // {{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6 | ||
| previousStableJetBrainsBackendPluginVersion := "commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The value is a copy current stable backend plugin image from main build |
||
|
|
||
| configTmpl := ConfigTemplate{ | ||
| Repository: ctx.Config.Repository, | ||
| IdeLogoBase: fmt.Sprintf("https://ide.%s/image/ide-logo", ctx.Config.Domain), | ||
|
|
@@ -76,6 +80,7 @@ func GenerateIDEConfigmap(ctx *common.RenderContext) (*ide_config.IDEConfig, err | |
| CodeWebExtensionImage: ctx.ImageName(ctx.Config.Repository, ide.CodeWebExtensionImage, ctx.VersionManifest.Components.Workspace.CodeWebExtensionImage.Version), | ||
|
|
||
| JetBrainsPluginImage: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.JetBrainsBackendPluginImage.Version), | ||
| JetBrainsPluginImagePrevious: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, previousStableJetBrainsBackendPluginVersion), | ||
| JetBrainsPluginLatestImage: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.JetBrainsBackendPluginLatestImage.Version), | ||
| JetBrainsPluginRiderImage: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.JetBrainsBackendPluginRiderImage.Version), | ||
| JetBrainsPluginLatestRiderImage: ctx.ImageName(ctx.Config.Repository, ide.JetBrainsBackendPluginImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.JetBrainsBackendPluginLatestRiderImage.Version), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To unblock rider plugin build