Skip to content

Don't be so chatty when hasReadAccess throws #20400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Don't be so chatty when hasReadAccess throws #20400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions components/server/src/bitbucket/bitbucket-repository-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,15 +123,14 @@ export class BitbucketRepositoryProvider implements RepositoryProvider {

async hasReadAccess(user: User, owner: string, repo: string): Promise<boolean> {
const api = await this.apiFactory.create(user);
try {
await api.repositories.get({ workspace: owner, repo_slug: repo });
// we assume that if the current token is good to read the repository details,
// then the repository is accessible
return true;
} catch (err) {
console.warn({ userId: user.id }, "hasReadAccess error", err, { owner, repo });
return false;
}
const result = await api.repositories.get({ workspace: owner, repo_slug: repo }).catch((e) => {
console.warn({ userId: user.id }, "hasReadAccess error", { owner, repo, status: e.status });
return null;
});

// we assume that if the current token is good to read the repository details,
// then the repository is accessible
return result !== null;
}

public async getCommitHistory(
Expand Down
Loading