Skip to content

Commit bce946e

Browse files
authored
Merge pull request microsoft#182615 from tisilent/microsoft#182303
Fix contributed profile icons
2 parents 773af96 + a1dd463 commit bce946e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -486,8 +486,9 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
486486
const defaultProfile = (await this._terminalProfileResolverService.getDefaultProfile({ remoteAuthority: this.remoteAuthority, os }));
487487
this.shellLaunchConfig.executable = defaultProfile.path;
488488
this.shellLaunchConfig.args = defaultProfile.args;
489-
this.shellLaunchConfig.icon = defaultProfile.icon;
490-
this.shellLaunchConfig.color = defaultProfile.color;
489+
// Only use default icon and color if they are undefined in the SLC
490+
this.shellLaunchConfig.icon ??= defaultProfile.icon;
491+
this.shellLaunchConfig.color ??= defaultProfile.color;
491492
}
492493

493494
await this._createProcess();

0 commit comments

Comments
 (0)