Closed
Conversation
Solving compile errors for macos
Bump version number to 1.3.2
changing type of min_depth from uint8_t to uint32_t
… trim_io � Conflicts: � src/trim_primer_quality.cpp
Updating for the acceptance of stdin
Update Dockerfile htslib version and ubuntu version
Attempting to build ivar up to version 1.4.1 with Gcc 13 will result with the following errors: primer_bed.h:13:3: error: ‘uint32_t’ does not name a type 13 | uint32_t start; // 0 based | ^~~~~~~~ primer_bed.h:6:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’? 5 | #include <vector> +++ |+#include <cstdint> 6 | […] parse_gff.h:47:3: error: ‘uint64_t’ does not name a type 47 | uint64_t get_start(); | ^~~~~~~~ parse_gff.h:6:1: note: ‘uint64_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’? 5 | #include <regex> +++ |+#include <cstdint> 6 | #include <sstream> Per the hints, this patch will resolve the build problem with the newer compiler version. This problem has been initially reported in [Debian Bug#1037700]. [Debian Bug#1037700]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037700 Signed-off-by: Étienne Mollier <emollier@debian.org>
… in gff file in ivar variants
# Conflicts: # tests/Makefile.am
* Install autoconf with brew. * Bumped up htslib version for macos.
fix build failure with gcc-13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping Ubuntu version from 20.04 to 22.04 in workflows.