-
-
Notifications
You must be signed in to change notification settings - Fork 156
Updated three.js to 0.181.1 #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixing this kind of thing correctly is the exact thing AI should be good for... 🤦 😅 Can you try adding the following to the typescript file under "compilerOptions", instead? See the three-mesh-bvh tsconfig file. "lib": [ "dom", "es2017" ],
"module": "node20", |
Done! |
|
Oh, the Node.js CI is failing now. Did you want me to keep |
I'll take a look at this when I have time. SkipLibCheck seems to basically makes typechecking useless. |
|
Fun stuff 😁 |
|
@Methuselah96 any idea why we might be seeing this typescript error?
|
|
This can be fixed by updating |
|
Thanks - just fixed it. I agree it would be better if a minimum version could be set. |
|
👍 Looks like DefinitelyTyped allows it. 🎉 Will be enforced in the next version of |

This PR updates the three.js dependency to 0.181.1
I asked Claude why that
skipLibCheckboolean was added and it said this:Which sound like fun TypeScript stuff I don't want to know about 😇