Viewer: Fix camera not resetting properly when dropping multiple models #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
Nov 17, 2025
Comment on lines
+166
to
+168
| // Reset camera and controls | ||
| camera.position.set( 0, 0, distance ); | ||
| camera.lookAt( 0, 0, 0 ); |
Owner
There was a problem hiding this comment.
How does this fix it? The position is set to the same value and "lookAt" is called in controls.update so isn't this the same thing as before?
Contributor
Author
There was a problem hiding this comment.
I'll test later today. Maybe I was using an old bundle or something. This whole parcel/vite process for updating examples confuses me.
Contributor
Author
|
Looks like it was indeed an issue with parcel/vite not updating the file or something. |
Owner
|
Yeah Parcel I used to have issues with - but vite has been pretty reliable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #700
Fixes an issue where the camera would appear to move progressively further away when dropping multiple models in the viewer.