Skip to content

Viewer: Fix camera not resetting properly when dropping multiple models #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrdoob wants to merge 1 commit into from
Closed

Viewer: Fix camera not resetting properly when dropping multiple models #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion example/viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,14 @@ async function init() {
const maxDim = Math.max( size.x, size.y, size.z );
const fov = camera.fov * ( Math.PI / 180 );
const distance = maxDim / ( 2 * Math.tan( fov / 2 ) ) * 1.5;
camera.position.set( 0, 0, distance );

camera.near = maxDim / 100;
camera.far = maxDim * 10;
camera.updateProjectionMatrix();

// Reset camera and controls
camera.position.set( 0, 0, distance );
camera.lookAt( 0, 0, 0 );
Comment on lines +166 to +168
Copy link
Owner

@gkjohnson gkjohnson Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this fix it? The position is set to the same value and "lookAt" is called in controls.update so isn't this the same thing as before?

Copy link
Contributor Author

@mrdoob mrdoob Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test later today. Maybe I was using an old bundle or something. This whole parcel/vite process for updating examples confuses me.

controls.target.set( 0, 0, 0 );
controls.update();

Expand Down
Loading