Fixes #4984

[baraich]

When trying to specify return types for a function using a :, it now displays a better error message.

[lpil]

Thank you! Could you use an if let Some with an early return for this please, similar to the error above for FunctionDefinitionAngleGenerics.

We'll need tests to be added too. The ones for FunctionDefinitionAngleGenerics would be a good example for what they would look like, you can see them in this PR #4818

[baraich]

@lpil, I need your help in writing tests for these changes. I have written the following test; however, it is failing.

#[test]
fn wrong_function_return_type_declaration_using_colon_instead_of_right_arrow() {
    assert_module_error!(
        r#"
pub fn main(): Nil {}
        "#
    );
}

[GearsDatapacks]

You probably need to accept the snapshot. We use snapshot testing in the Gleam compiler, so once you run the test, you need to run cargo insta review. Then you look at the output (in this case the error message) and you decide whether or not it is correct. See docs/compiler/README.md for more information

[baraich]

@GearsDatapacks, please review the pull request.

[GearsDatapacks]

Looks good! One tiny note

[baraich]

@GearsDatapacks, I have updated the code with the suggested change.

[GearsDatapacks]

Looks good to me! Need Louis to review it before merging though

[baraich]

@lpil Please review the pull request.

[lpil]

Lovely work! Thank you very much!

I've left one tiny note inline, and would you mind updating the changelog too please 🙏

[lpil]

Ah! The build is failing because of a CI problem. If you rebase on main to the latest code changes then it should be fixed.

[baraich]

@lpil, I will rebase it on the main branch and update the CHANGELOG.md file.

[baraich]

@lpil, Please review the pull request.

[lpil]

You've done a merge commit rather than a rebase, so the build is failing as we do not permit them. Could you rebase on main please 🙏 That will remove the merge commit for you.

[baraich]

@lpil, I have no idea how to perform a rebase. Now, how do I revert the accidental merge? I just ran git pull --rebase on the main branch.

[inoas]

@baraich I think we could possibly help you out on community discord.

[baraich]

@inoas, is there an invite link?

[inoas]

@inoas, is there an invite link?

https://gleam.run/community/

[ankddev]

@baraich https://discord.gg/gyhPbVBSzS