-
-
Notifications
You must be signed in to change notification settings - Fork 873
Fixes #4984 #4992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
baraich
wants to merge
12
commits into
gleam-lang:main
Choose a base branch
from
baraich:fixes-issue-4984
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−0
Open
Fixes #4984 #4992
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
476223f
Fixes #4984
baraich 4990ba9
update the code to use early return
baraich 387bc09
added tests for #4984
baraich 6058b4f
wrapping operators in backticks
baraich b23c35a
Merge branch 'main' of baraich:baraich/gleam
baraich 766fb30
update the code to use early return
baraich 3d5fb4f
added tests for #4984
baraich c10bbfc
wrapping operators in backticks
baraich 7f58949
updated CHANGELOG.md file with change description
baraich a135980
Merge branch 'fixes-issue-4984' of baraich:baraich/gleam into fixes-i…
baraich 9830e02
update the hint message
baraich 68a84e4
update the snapshot
baraich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...se__tests__wrong_function_return_type_declaration_using_colon_instead_of_right_arrow.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
source: compiler-core/src/parse/tests.rs | ||
expression: "\npub fn main(): Nil {}\n " | ||
--- | ||
----- SOURCE CODE | ||
|
||
pub fn main(): Nil {} | ||
|
||
|
||
----- ERROR | ||
error: Syntax error | ||
┌─ /src/parse/error.gleam:2:14 | ||
│ | ||
2 │ pub fn main(): Nil {} | ||
│ ^ I was not expecting this | ||
|
||
Found `:`, expected one of: | ||
- `->` | ||
Hint: Maybe you meant to write return value type annotation? | ||
Return type annotations are written using `->`, not `:` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.