Skip to content

feat: add GLEAN_SERVER_URL support with highest priority#344

Merged
chris-freeman-glean merged 2 commits intomainfrom
cfreeman/server-url-migration
Mar 5, 2026
Merged

feat: add GLEAN_SERVER_URL support with highest priority#344
chris-freeman-glean merged 2 commits intomainfrom
cfreeman/server-url-migration

Conversation

@chris-freeman-glean
Copy link
Contributor

Summary

  • GLEAN_SERVER_URL env var with highest priority in config resolution
  • --server-url / -s CLI flag for local-mcp-server
  • normalizeUrl() helper adds https:// to schemeless URLs
  • validateInstance() handles full URLs, skips instance-name validation when server URL is set
  • Priority: GLEAN_SERVER_URL > GLEAN_URL > GLEAN_INSTANCE/GLEAN_SUBDOMAIN
  • No breaking changes — all existing env vars continue working
  • Part of the instance → server_url migration for DNS obfuscation support

Test plan

  • All 121 tests pass (67 mcp-server-utils + 54 local-mcp-server)
  • GLEAN_SERVER_URL precedence over GLEAN_URL and GLEAN_INSTANCE
  • Schemeless URL normalization
  • Smoke test with real GLEAN_SERVER_URL

@chris-freeman-glean chris-freeman-glean marked this pull request as ready for review March 4, 2026 21:13
@chris-freeman-glean chris-freeman-glean requested a review from a team as a code owner March 4, 2026 21:13
@chris-freeman-glean chris-freeman-glean merged commit bd6da3f into main Mar 5, 2026
4 checks passed
@chris-freeman-glean chris-freeman-glean deleted the cfreeman/server-url-migration branch March 5, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant