Skip to content

Conversation

@Davphla
Copy link
Member

@Davphla Davphla commented Dec 18, 2025

fix: #4529
fix: #4997

queryGasPrice function can be found in tm2/pkg/sdk/auth/handler.go:L83.

Reference: #2838

@github-actions github-actions bot added the 📖 documentation Improvements or additions to documentation label Dec 18, 2025
@Gno2D2 Gno2D2 requested a review from a team December 18, 2025 14:55
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 18, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 18, 2025

🛠 PR Checks Summary

🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: Davphla/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^docs/ (filename: docs/resources/gas-fees.md)

Then

🔴 Requirement not satisfied
└── 🔴 And
    ├── 🔴 Or
    │   ├── 🔴 Pull request author is a member of the team: tech-staff
    │   └── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request(with state "APPROVED")
    └── 🔴 Or
        ├── 🔴 Pull request author is a member of the team: devrels
        └── 🔴 At least 1 user(s) of the team devrels reviewed pull request(with state "APPROVED")

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 User MikaelVallenet already reviewed PR 4995 with state APPROVED
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@Davphla Davphla marked this pull request as draft December 18, 2025 14:57
@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 18, 2025
@Davphla Davphla marked this pull request as ready for review December 18, 2025 17:05
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 18, 2025
@Davphla Davphla marked this pull request as draft December 18, 2025 17:32
@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 18, 2025
@Davphla Davphla changed the title docs(gnokey): add auth/gasprice query endpoint docs(gnokey): gas price Dec 18, 2025
@Davphla Davphla changed the title docs(gnokey): gas price docs: add auth/gasprice query documentation and gas price mechanism explanation Dec 18, 2025
@Davphla Davphla marked this pull request as ready for review December 18, 2025 18:34
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 18, 2025
**Example:**
```bash
# Query returns: {gas: 1000, price: "100ugnot"}
# Rate = 100 ÷ 1000 = 0.1 ugnot/gas
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be a good idea to calculate that rate automatically when calling auth/gasprice

Copy link
Member

@MikaelVallenet MikaelVallenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Gas Price section would be nice to maybe explain what happens in case of error (e.g gas too low and give an example) it could help newcomers facing gas issues to identify the solution faster wdyt ?

Comment on lines 102 to 105
**Note**: Individual validators can also set their own minimum gas price. When you
submit a transaction, it must meet both the network gas price AND the minimum set
by the specific validator node you're sending to. Different validators may have
different minimums.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a doc or link to explain more about this (how a validator can set minimum ...blabla)
if not it's fine but feel like it can be good here since it's a small note and people may be interested to learn more about validators config when reading this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: 1dff049
The documentation does not exist on the mono-repo.
There's existing explanation on https://gnops.io/articles/guides/local-chain/#1-generate-the-node-directory-secrets--config, but it is explained implicitly.

Copy link
Member

@MikaelVallenet MikaelVallenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, i let some comment that would be improvements IMO

@Kouteki Kouteki requested review from moul and zivkovicmilos and removed request for a team December 22, 2025 20:49
@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️Gno.land development Dec 22, 2025
@Gno2D2 Gno2D2 requested a review from a team December 25, 2025 18:11
Copy link
Contributor

@Villaquiranm Villaquiranm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice doc :) LGTM

@jefft0
Copy link
Contributor

jefft0 commented Jan 9, 2026

MikaelVallenet approved. Ready for core dev review.

@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 documentation Improvements or additions to documentation

Projects

Status: No status
Status: In Review

Development

Successfully merging this pull request may close these issues.

docs: document dynamic gas price mechanism Docs: auth/gasprice

5 participants