-
Notifications
You must be signed in to change notification settings - Fork 445
docs: add auth/gasprice query documentation and gas price mechanism explanation #4995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
…and interact-with-gnokey documentation
| **Example:** | ||
| ```bash | ||
| # Query returns: {gas: 1000, price: "100ugnot"} | ||
| # Rate = 100 ÷ 1000 = 0.1 ugnot/gas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be a good idea to calculate that rate automatically when calling auth/gasprice
MikaelVallenet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Gas Price section would be nice to maybe explain what happens in case of error (e.g gas too low and give an example) it could help newcomers facing gas issues to identify the solution faster wdyt ?
docs/resources/gas-fees.md
Outdated
| **Note**: Individual validators can also set their own minimum gas price. When you | ||
| submit a transaction, it must meet both the network gas price AND the minimum set | ||
| by the specific validator node you're sending to. Different validators may have | ||
| different minimums. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a doc or link to explain more about this (how a validator can set minimum ...blabla)
if not it's fine but feel like it can be good here since it's a small note and people may be interested to learn more about validators config when reading this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: 1dff049
The documentation does not exist on the mono-repo.
There's existing explanation on https://gnops.io/articles/guides/local-chain/#1-generate-the-node-directory-secrets--config, but it is explained implicitly.
MikaelVallenet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, i let some comment that would be improvements IMO
Villaquiranm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice doc :) LGTM
|
MikaelVallenet approved. Ready for core dev review. |
fix: #4529
fix: #4997
queryGasPricefunction can be found intm2/pkg/sdk/auth/handler.go:L83.Reference: #2838